CLOSED DUPLICATE of bug 28291 51561
webkit-patch land should refuse to land if ChangeLog diffs are not at the top 
https://bugs.webkit.org/show_bug.cgi?id=51561
Summary webkit-patch land should refuse to land if ChangeLog diffs are not at the top
Darin Adler
Reported 2010-12-23 14:42:15 PST
If you merge wrong, then webkit-patch land will check in and attach the wrong ChangeLog. This could be avoided if webkit-patch checked and refused to land if the only ChangeLog changes are somewhere other than the top of the log.
Attachments
Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-12-23 14:47:38 PST
I completely agree. It's a little tricky (we don't currently have python code for parsing diffs, and one needs to allow diffs to be up to some N lines from the top in teh case where its the second commit from the same bug/review/etc.) we should probably dup this to bug 28291. But I guess I should finally take another crack at it. *** This bug has been marked as a duplicate of bug 28291 ***
Note You need to log in before you can comment on or make changes to this bug.