Bug 51561 - webkit-patch land should refuse to land if ChangeLog diffs are not at the top
Summary: webkit-patch land should refuse to land if ChangeLog diffs are not at the top
Status: CLOSED DUPLICATE of bug 28291
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-23 14:42 PST by Darin Adler
Modified: 2010-12-23 14:52 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2010-12-23 14:42:15 PST 
If you merge wrong, then webkit-patch land will check in and attach the wrong ChangeLog. This could be avoided if webkit-patch checked and refused to land if the only ChangeLog changes are somewhere other than the top of the log.
Comment 1 Eric Seidel (no email) 2010-12-23 14:47:38 PST 
I completely agree.  It's a little tricky (we don't currently have python code for parsing diffs, and one needs to allow diffs to be up to some N lines from the top in teh case where its the second commit from the same bug/review/etc.)

we should probably dup this to bug 28291.  But I guess I should finally take another crack at it.

*** This bug has been marked as a duplicate of bug 28291 ***