WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
51550
Clean up the selection handling code
https://bugs.webkit.org/show_bug.cgi?id=51550
Summary
Clean up the selection handling code
Anders Carlsson
Reported
2010-12-23 11:57:17 PST
Clean up the selection handling code
Attachments
Patch
(32.37 KB, patch)
2010-12-23 12:03 PST
,
Anders Carlsson
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-12-23 12:03:28 PST
Created
attachment 77355
[details]
Patch
Darin Adler
Comment 2
2010-12-23 12:40:24 PST
Comment on
attachment 77355
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=77355&action=review
> WebKit2/Shared/SelectionState.h:39 > + , selectedRangeStart(static_cast<uint64_t>(-1))
Can we have a named constant for this? What does it mean? Is it ever exposed to clients of the WK API?
> WebKit2/UIProcess/WebPageProxy.h:177 > + // These are only used on Mac currently.
Seems like a silly comment just before #if PLATFORM(MAC). Is there something more substantive to say about these functions?
> WebKit2/UIProcess/WebPageProxy.h:497 > + // The current selection state. > + SelectionState m_selectionState;
Comment adds little. Leave it out?
> WebKit2/WebProcess/WebPage/WebPage.cpp:616 > + location = static_cast<uint64_t>(-1);
Use that constant from above?
Darin Adler
Comment 3
2010-12-23 14:40:45 PST
Anders committed
r74582
: <
http://trac.webkit.org/changeset/74582
>.
WebKit Review Bot
Comment 4
2010-12-23 15:31:46 PST
http://trac.webkit.org/changeset/74583
might have broken Qt Linux Release The following tests are not passing: inspector/styles-new-API.html
Eric Seidel (no email)
Comment 5
2010-12-23 15:35:48 PST
I suspect that's just a flaky test:
https://bugs.webkit.org/show_bug.cgi?id=50889
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug