Bug 51550 – Clean up the selection handling code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Clean up the selection handling code

[Anders Carlsson]

Created attachment 77355 [details]
Patch

[Darin Adler]

Comment on attachment 77355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77355&action=review

> WebKit2/Shared/SelectionState.h:39
> +        , selectedRangeStart(static_cast<uint64_t>(-1))

Can we have a named constant for this? What does it mean? Is it ever exposed to clients of the WK API?

> WebKit2/UIProcess/WebPageProxy.h:177
> +    // These are only used on Mac currently.

Seems like a silly comment just before #if PLATFORM(MAC). Is there something more substantive to say about these functions?

> WebKit2/UIProcess/WebPageProxy.h:497
> +    // The current selection state.
> +    SelectionState m_selectionState;

Comment adds little. Leave it out?

> WebKit2/WebProcess/WebPage/WebPage.cpp:616
> +    location = static_cast<uint64_t>(-1);

Use that constant from above?

[Darin Adler]

Anders committed r74582: <http://trac.webkit.org/changeset/74582>.

[WebKit Review Bot]

http://trac.webkit.org/changeset/74583 might have broken Qt Linux Release
The following tests are not passing:
inspector/styles-new-API.html

[Eric Seidel (no email)]

I suspect that's just a flaky test: https://bugs.webkit.org/show_bug.cgi?id=50889