RESOLVED FIXED 51548
check-webkit-style doesn't check all of the ports when linting test expectations 
https://bugs.webkit.org/show_bug.cgi?id=51548
Summary check-webkit-style doesn't check all of the ports when linting test expectations
Dirk Pranke
Reported 2010-12-23 11:33:31 PST
The code in the TestExpectations style checker only lints the test expectations file against the port it is running on. It really should be linting against all ports, like new-run-webkit-tests --lint-test-files does. The easiest fix is to just have it call into the lint routines in webkitpy/layout_tests ... I should probably refactor that logic out of TestRunner and into test_expectations.
Attachments
Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-12-23 11:34:21 PST
There's no point in fixing this before we fix/land 51222, since all of the logic changes in that fix.
Dirk Pranke
Comment 2 2010-12-23 11:42:10 PST
Bug 51500 gave a false positive on the style bot because of this (as an example).
Dirk Pranke
Comment 3 2010-12-23 11:43:53 PST
There's also a lot of testing duplicated between the style checker and the unit tests for the expectations parser that's kind of unnecessary and can lead to confusion (see, e.g. bug 48426 for an example where one set of tests was updated but the other wasn't).
Dirk Pranke
Comment 4 2012-09-27 12:34:48 PDT
I'm pretty sure I fixed this a while ago. It seems to e be working now.
Note You need to log in before you can comment on or make changes to this bug.