RESOLVED FIXED51532
[GTK] Add volume slider to media player 
https://bugs.webkit.org/show_bug.cgi?id=51532
Summary [GTK] Add volume slider to media player
Carlos Garcia Campos
Reported 2010-12-23 03:54:41 PST
Current media player only allows mute/unmute but it doesn't have a volume slider to change the volume.
Attachments
Patch to render volume slider in media player (7.33 KB, patch)
2010-12-23 04:00 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
updated baselines (18.02 KB, patch)
2010-12-23 06:02 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Updated patch to current git master (11.14 KB, patch)
2011-01-11 09:51 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
updated baselines (20.93 KB, patch)
2011-01-13 08:53 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch with the new baselines (32.07 KB, patch)
2011-01-14 00:46 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2010-12-23 04:00:23 PST
Created attachment 77323 [details] Patch to render volume slider in media player
Philippe Normand
Comment 2 2010-12-23 04:52:37 PST
New baselines will be required for some media tests. Example for media/video-display-toggle.html layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 layer at (0,0) size 800x600 RenderBlock {HTML} at (0,0) size 800x600 RenderBody {BODY} at (8,8) size 784x584 RenderText {#text} at (0,0) size 493x19 text run at (0,0) width 493: "This tests that toggling the display property won't make the controls disappear." RenderBR {BR} at (493,15) size 0x0 RenderText {#text} at (0,0) size 0x0 layer at (8,27) size 320x240 RenderVideo {VIDEO} at (0,19) size 320x240 layer at (8,27) size 320x240 RenderBlock (relative positioned) {DIV} at (0,0) size 320x240 layer at (8,27) size 320x240 RenderFlexibleBox (positioned) {DIV} at (0,0) size 320x240 RenderButton {INPUT} at (0,220) size 20x20 RenderFlexibleBox {DIV} at (20,220) size 220x20 [border: (1px solid #FFFFFF33) none (1px solid #FFFFFF33)] RenderSlider {INPUT} at (1,0) size 218x20 RenderBlock {DIV} at (2,4) size 12x12 RenderButton {INPUT} at (240,220) size 20x20 RenderButton {INPUT} at (260,220) size 20x20 RenderButton {INPUT} at (280,220) size 20x20 RenderButton {INPUT} at (300,220) size 20x20
Philippe Normand
Comment 3 2010-12-23 04:58:04 PST
The diff for this test is: --- /tmp/layout-test-results/media/video-display-toggle-expected.txt 2010-12-23 13:54:37.000000000 +0100 +++ /tmp/layout-test-results/media/video-display-toggle-actual.txt 2010-12-23 13:54:37.000000000 +0100 @@ -11,13 +11,13 @@ RenderVideo {VIDEO} at (0,19) size 320x240 layer at (8,27) size 320x240 RenderBlock (relative positioned) {DIV} at (0,0) size 320x240 -layer at (8,247) size 320x20 - RenderFlexibleBox (positioned) {DIV} at (0,220) size 320x20 - RenderButton {INPUT} at (0,0) size 20x20 - RenderFlexibleBox {DIV} at (20,0) size 220x20 [border: (1px solid #FFFFFF33) none (1px solid #FFFFFF33)] +layer at (8,27) size 320x240 + RenderFlexibleBox (positioned) {DIV} at (0,0) size 320x240 + RenderButton {INPUT} at (0,220) size 20x20 + RenderFlexibleBox {DIV} at (20,220) size 220x20 [border: (1px solid #FFFFFF33) none (1px solid #FFFFFF33)] RenderSlider {INPUT} at (1,0) size 218x20 RenderBlock {DIV} at (2,4) size 12x12 - RenderButton {INPUT} at (240,0) size 20x20 - RenderButton {INPUT} at (260,0) size 20x20 - RenderButton {INPUT} at (280,0) size 20x20 - RenderButton {INPUT} at (300,0) size 20x20 + RenderButton {INPUT} at (240,220) size 20x20 + RenderButton {INPUT} at (260,220) size 20x20 + RenderButton {INPUT} at (280,220) size 20x20 + RenderButton {INPUT} at (300,220) size 20x20
Philippe Normand
Comment 4 2010-12-23 06:02:58 PST
Created attachment 77329 [details] updated baselines Will need a changelog if you land this :)
Carlos Garcia Campos
Comment 5 2011-01-11 09:51:54 PST
Created attachment 78545 [details] Updated patch to current git master It still needs new baselines, I couldn't create them because several media tests fail for me due to the gst version I have installed.
Philippe Normand
Comment 6 2011-01-13 08:53:27 PST
Created attachment 78816 [details] updated baselines
Carlos Garcia Campos
Comment 7 2011-01-14 00:46:43 PST
Created attachment 78901 [details] Patch with the new baselines
Martin Robinson
Comment 8 2011-01-14 08:44:30 PST
Comment on attachment 78901 [details] Patch with the new baselines Looks good!
Carlos Garcia Campos
Comment 9 2011-01-14 09:28:12 PST
Committed r75798: <http://trac.webkit.org/changeset/75798>
Note You need to log in before you can comment on or make changes to this bug.