ScriptController::evaluate contains: if (object.IsEmpty() || object->IsUndefined()) return ScriptValue(); Should be: if (object.IsEmpty()) return ScriptValue(); Returning an empty ScriptValue should indicate an error. As undefined is a valid return value for void calls returning an empty ScriptValue makes it impossible to distinguish undefined results from errors. Related mailing list thread: https://lists.webkit.org/pipermail/webkit-dev/2010-December/015417.html
Created attachment 77331 [details] fix, allow the "undefined" v8 object to be returned
Hi Yury, please review this patch.
Comment on attachment 77331 [details] fix, allow the "undefined" v8 object to be returned This patch was not created correctly. Please create from a WebKit checkout. Also, all patches require a ChangeLog. webkit-patch upload will walk you through much of this.
Hi Tom, please add proper ChangeLog entry to the patch as Eric suggested, otherwise the change looks good to me. (In reply to comment #2) > Hi Yury, please review this patch.
Created attachment 83357 [details] Patch
Generated a patch with webkit-patch upload and included a ChangeLog. Let me know if anything else is needed.
Can someone add this patch to the commit queue? Thanks.
Comment on attachment 83357 [details] Patch Clearing flags on attachment: 83357 Committed r79981: <http://trac.webkit.org/changeset/79981>
All reviewed patches have been landed. Closing bug.