Bug 51513 - REGRESSION(r74503): breaks chromium mac debug compile (Requested by tonyg-cr on #webkit).
Summary: REGRESSION(r74503): breaks chromium mac debug compile (Requested by tonyg-cr ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 51186
  Show dependency treegraph
 
Reported: 2010-12-22 18:41 PST by WebKit Review Bot
Modified: 2010-12-22 18:47 PST (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r74503 (4.52 KB, patch)
2010-12-22 18:41 PST, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2010-12-22 18:41:03 PST
http://trac.webkit.org/changeset/74503 broke the build:
breaks chromium mac debug compile (Requested by tonyg-cr on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-12-22 18:41:20 PST
Created attachment 77291 [details]
ROLLOUT of r74503

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Tony Gentilcore 2010-12-22 18:44:24 PST
Comment on attachment 77291 [details]
ROLLOUT of r74503

Clearing flags on attachment: 77291

Committed r74529: <http://trac.webkit.org/changeset/74529>
Comment 3 Tony Gentilcore 2010-12-22 18:44:28 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Tony Gentilcore 2010-12-22 18:45:14 PST
Here was the error:

CompileC ../../../../xcodebuild/WebCore.build/Debug/webcore_platform.build/Objects-normal/i386/ImageLayerChromium.o ../platform/graphics/chromium/ImageLayerChromium.cpp normal i386 c++ com.apple.compilers.gcc.4_2
    cd /b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp
    setenv LANG en_US.US-ASCII
    /Developer/usr/bin/gcc-4.2 -x c++ -arch i386 -fmessage-length=0 -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -O0 -Werror -Wnewline-eof -DCHROMIUM_BUILD -DENABLE_REMOTING=1 -DENABLE_GPU=1 "-DWEBCORE_NAVIGATOR_VENDOR=\"Google Inc.\"" -DENABLE_3D_CANVAS=1 -DENABLE_3D_PLUGIN=1 -DENABLE_BLOB=1 -DENABLE_BLOB_SLICE=1 -DENABLE_CHANNEL_MESSAGING=1 -DENABLE_CLIENT_BASED_GEOLOCATION=0 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_DATABASE=1 -DENABLE_DATAGRID=0 -DENABLE_DEVICE_ORIENTATION=1 -DENABLE_DIRECTORY_UPLOAD=1 -DENABLE_DOM_STORAGE=1 -DENABLE_EVENTSOURCE=1 -DENABLE_FILE_SYSTEM=1 -DENABLE_FILTERS=1 -DENABLE_GEOLOCATION=1 -DENABLE_ICONDATABASE=0 -DENABLE_INDEXED_DATABASE=1 -DENABLE_INPUT_SPEECH=1 -DENABLE_JAVASCRIPT_DEBUGGER=1 -DENABLE_JSC_MULTIPLE_THREADS=0 -DENABLE_LINK_PREFETCH=1 -DENABLE_METER_TAG=1 -DENABLE_NOTIFICATIONS=1 -DENABLE_OFFLINE_WEB_APPLICATIONS=1 -DENABLE_OPENTYPE_SANITIZER=1 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_PROGRESS_TAG=1 -DENABLE_RUBY=1 -DENABLE_SANDBOX=1 -DENABLE_SHARED_WORKERS=1 -DENABLE_SVG=1 -DENABLE_SVG_ANIMATION=1 -DENABLE_SVG_AS_IMAGE=1 -DENABLE_SVG_FONTS=1 -DENABLE_SVG_FOREIGN_OBJECT=1 -DENABLE_SVG_USE=1 -DENABLE_TOUCH_EVENTS=1 -DENABLE_V8_SCRIPT_DEBUG_SERVER=1 -DENABLE_VIDEO=1 -DENABLE_WEB_SOCKETS=1 -DENABLE_WEB_TIMING=1 -DENABLE_WORKERS=1 -DENABLE_XHR_RESPONSE_BLOB=1 -DENABLE_XPATH=1 -DENABLE_XSLT=1 -DWTF_USE_WEBP=1 -DWTF_USE_WEBKIT_IMAGE_DECODERS=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DENABLE_3D_RENDERING=1 -DENABLE_ACCELERATED_2D_CANVAS=1 -DBUILDING_CHROMIUM__=1 -DUSE_SYSTEM_MALLOC=1 -DWTF_USE_NEW_THEME=1 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DLIBXML_STATIC -DLIBXSLT_STATIC -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -isysroot /Developer/SDKs/MacOSX10.5.sdk -fvisibility=hidden -fvisibility-inlines-hidden -fno-threadsafe-statics -mmacosx-version-min=10.5 -gdwarf-2 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -F/b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/Debug -F/Developer/SDKs/MacOSX10.5.sdk/System/Library/Frameworks/ApplicationServices.framework/Frameworks -I/b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/Debug/include -I../../../icu/public/common -I../../../icu/public/i18n -I../../WebKitLibraries -I../../../../gpu -I/b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/WebCore.build/DerivedSources/Debug -I../platform/graphics/cocoa -I../platform/graphics/cg -I.. -I../accessibility -I../accessibility/chromium -I../bindings -I../bindings/generic -I../bindings/v8 -I../bindings/v8/custom -I../bindings/v8/specialization -I../css -I../dom -I../dom/default -I../editing -I../fileapi -I../history -I../html -I../html/canvas -I../html/parser -I../html/shadow -I../inspector -I../loader -I../loader/appcache -I../loader/archive -I../loader/cache -I../loader/icon -I../mathml -I../notifications -I../page -I../page/animation -I../page/chromium -I../platform -I../platform/animation -I../platform/audio -I../platform/audio/chromium -I../platform/chromium -I../platform/graphics -I../platform/graphics/chromium -I../platform/graphics/filters -I../platform/graphics/gpu -I../platform/graphics/opentype -I../platform/graphics/skia -I../platform/graphics/transforms -I../platform/image-decoders -I../platform/image-decoders/bmp -I../platform/image-decoders/gif -I../platform/image-decoders/ico -I../platform/image-decoders/jpeg -I../platform/image-decoders/png -I../platform/image-decoders/skia -I../platform/image-decoders/xbm -I../platform/image-decoders/webp -I../platform/image-encoders/skia -I../platform/mock -I../platform/network -I../platform/network/chromium -I../platform/sql -I../platform/text -I../platform/text/transcoder -I../plugins -I../plugins/chromium -I../rendering -I../rendering/style -I../rendering/svg -I../storage -I../storage/chromium -I../svg -I../svg/animation -I../svg/graphics -I../svg/graphics/filters -I../svg/properties -I../webaudio -I../websockets -I../workers -I../xml -I../loader/archive/cf -I../platform/audio/mac -I../platform/graphics/mac -I../platform/mac -I../platform/text/mac -I../../../../third_party/angle/include/GLSLANG -I/b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/DerivedSources/Debug/webkit -I/b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/DerivedSources/Debug/webkit/bindings -I../../JavaScriptCore -I../../JavaScriptCore/wtf -I../../../.. -I../../../../skia/config -I../../../../third_party/skia/include/config -I../../../../third_party/skia/include/core -I../../../../third_party/skia/include/effects -I../../../../skia/ext -I../../../iccjpeg -I../../../libwebp -I../../../libwebp/webp -I../../../libpng -I../../../zlib -I../../../libxml/mac/include -I../../../libxml/src/include -I../../../libxslt -I../../../npapi -I../../../npapi/bindings -I../../../ots/include -I../../../sqlite -I../../../libjpeg -I../../../../v8/include -I/b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/WebCore.build/Debug/webcore_platform.build/DerivedSources/i386 -I/b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/WebCore.build/Debug/webcore_platform.build/DerivedSources -include /b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../WebCorePrefix.h -c /b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../platform/graphics/chromium/ImageLayerChromium.cpp -o /b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/WebCore.build/Debug/webcore_platform.build/Objects-normal/i386/ImageLayerChromium.o

/b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../platform/graphics/chromium/ImageLayerChromium.cpp: In member function 'virtual void WebCore::ImageLayerChromium::updateContentsIfDirty()':
/b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../platform/graphics/chromium/ImageLayerChromium.cpp:162: error: 'skiaBitmap' was not declared in this scope
/b/build/slave/webkit-mac-dbg/build/src/third_party/WebKit/WebCore/WebCore.gyp/../platform/graphics/chromium/ImageLayerChromium.cpp:162: error: 'skiaConfig' was not declared in this scope