Bug 51505 - Detect WebProcess crashes sooner, without waiting for ReportCrash to finish
Summary: Detect WebProcess crashes sooner, without waiting for ReportCrash to finish
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-12-22 16:02 PST by Anders Carlsson
Modified: 2010-12-22 16:33 PST (History)
3 users (show)

See Also:


Attachments
Patch (9.73 KB, patch)
2010-12-22 16:07 PST, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-12-22 16:02:32 PST
Detect WebProcess crashes sooner, without waiting for ReportCrash to finish
Comment 1 Anders Carlsson 2010-12-22 16:02:50 PST
<rdar://problem/8751641>
Comment 2 Anders Carlsson 2010-12-22 16:07:45 PST
Created attachment 77270 [details]
Patch
Comment 3 Darin Adler 2010-12-22 16:11:58 PST
Comment on attachment 77270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77270&action=review

> WebKit2/Platform/CoreIPC/Connection.h:103
> +    // FIXME: Maybe this should be a flag passed to open?

Maybe, but do we really need leave a FIXME behind?

> WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp:112
> +        m_connectionQueue.registerMachPortEventHandler(m_exceptionPort, WorkQueue::MachPortDataAvailable,
> +                                                       WorkItem::create(this, &Connection::exceptionSourceEventHandler));

I do not like this indenting style. What happens when we rename something later? I think the style guide explicitly says not to do this.
Comment 4 Anders Carlsson 2010-12-22 16:15:42 PST
Committed r74514: <http://trac.webkit.org/changeset/74514>
Comment 5 WebKit Review Bot 2010-12-22 16:33:35 PST
http://trac.webkit.org/changeset/74514 might have broken SnowLeopard Intel Release (Build)