Bug 51483 - CSS 2.1 failure: counter-increment-013 fails
Summary: CSS 2.1 failure: counter-increment-013 fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-22 11:02 PST by Simon Fraser (smfr)
Modified: 2010-12-22 12:45 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.14 KB, patch)
2010-12-22 11:03 PST, Simon Fraser (smfr) 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-12-22 11:02:06 PST 
html4/counter-increment-013 fails.
Comment 1 Simon Fraser (smfr) 2010-12-22 11:03:20 PST 
Created attachment 77239 [details]
Patch
Comment 2 mitz 2010-12-22 11:07:22 PST 
Comment on attachment 77239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77239&action=review

> WebCore/css/CSSParser.cpp:131
> +    const double minIntAsDouble = INT_MIN;
> +    const double maxIntAsDouble = INT_MAX;

Please use numeric_limits<int> instead of the C macros.
Comment 3 Simon Fraser (smfr) 2010-12-22 11:19:47 PST 
http://trac.webkit.org/changeset/74491
Comment 4 WebKit Review Bot 2010-12-22 12:45:12 PST 
http://trac.webkit.org/changeset/74491 might have broken GTK Linux 32-bit Release
The following tests are not passing:
http/tests/local/stylesheet-and-script-load-order-media-print.html