Bug 51481 – AX: WAI-ARIA textbox role needs different AXRole, depending on value of aria-multiline property

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

AX: WAI-ARIA textbox role needs different AXRole, depending on value of aria-multiline property

Currently uses AXTextArea in all cases. Should use AXTextField by default unless it's a multiline text box, as defined below.

"If aria-multiline=”false” (default) use:
AXRole	AXTextField
AXRoleDescription	text field

If aria-multiline=”true” use:
AXRole	AXTextArea
AXRoleDescription	text entry area"

[chris fleizach]

http://www.w3.org/TR/wai-aria/complete#aria-multiline

[chris fleizach]

Created attachment 77233 [details]
Patch

[Darin Adler]

Comment on attachment 77233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77233&action=review

> WebCore/accessibility/AccessibilityObject.cpp:842
> +    return equalIgnoringCase(getAttribute(aria_multilineAttr), "true");

fastGetAttribute would be better here

[chris fleizach]

(In reply to comment #3)
> (From update of attachment 77233 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77233&action=review
> 
> > WebCore/accessibility/AccessibilityObject.cpp:842
> > +    return equalIgnoringCase(getAttribute(aria_multilineAttr), "true");
> 
> fastGetAttribute would be better here

the version of getAttribute in AccessibilityObject calls fastGetAttribute

[Darin Adler]

Comment on attachment 77233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77233&action=review

>>> WebCore/accessibility/AccessibilityObject.cpp:842
>>> +    return equalIgnoringCase(getAttribute(aria_multilineAttr), "true");
>> 
>> fastGetAttribute would be better here
> 
> the version of getAttribute in AccessibilityObject calls fastGetAttribute

Got it. Excellent.

[chris fleizach]

http://trac.webkit.org/changeset/74492

[WebKit Review Bot]

http://trac.webkit.org/changeset/74492 might have broken GTK Linux 64-bit Debug