Bug 51468 - Web Inspector: script name gets parsed as HTML in Call stack panel
Summary: Web Inspector: script name gets parsed as HTML in Call stack panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-22 06:02 PST by Yury Semikhatsky
Modified: 2010-12-23 02:42 PST (History)
11 users (show)

See Also:


Attachments
Screenshot (99.77 KB, image/png)
2010-12-22 06:08 PST, Yury Semikhatsky
no flags Details
Patch (1.14 KB, patch)
2010-12-22 06:11 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-12-22 06:02:19 PST
What steps will reproduce the problem?
1. Go to data:text/html,<div style="position:fixed;left:0;top:0;font-size:40px;z-index:999">Whoops</div><style>*{color:red!important}</style><script>debugger;</script>
2. Open inspector
3. Reload page to trigger the 'debugger' command and pause the execution

What is the expected output? What do you see instead?
The problem is that the 'Scripts' panel uses the data url as script name in 'Call Stack' panel and parses it as HTML - see screenshot for what happens in this case.
Comment 1 Yury Semikhatsky 2010-12-22 06:08:51 PST
Created attachment 77213 [details]
Screenshot
Comment 2 Yury Semikhatsky 2010-12-22 06:09:25 PST
Original Chromium bug report: http://crbug.com/67781
Comment 3 Yury Semikhatsky 2010-12-22 06:11:35 PST
Created attachment 77214 [details]
Patch
Comment 4 Joseph Pecoraro 2010-12-22 09:25:35 PST
Comment on attachment 77214 [details]
Patch

r=me, good fix. Should we audit any other uses of innerHTML in the inspector?
Comment 5 WebKit Commit Bot 2010-12-22 14:39:24 PST
Comment on attachment 77214 [details]
Patch

Clearing flags on attachment: 77214

Committed r74506: <http://trac.webkit.org/changeset/74506>
Comment 6 WebKit Commit Bot 2010-12-22 14:39:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Yury Semikhatsky 2010-12-23 02:42:00 PST
At first glance in other places we set innerHTML to values constructed by ourselves in the front-end code but we may want to double check this.

(In reply to comment #4)
> (From update of attachment 77214 [details])
> r=me, good fix. Should we audit any other uses of innerHTML in the inspector?