RESOLVED FIXED Bug 51468
Web Inspector: script name gets parsed as HTML in Call stack panel 
https://bugs.webkit.org/show_bug.cgi?id=51468
Summary Web Inspector: script name gets parsed as HTML in Call stack panel
Yury Semikhatsky
Reported 2010-12-22 06:02:19 PST
What steps will reproduce the problem? 1. Go to data:text/html,<div style="position:fixed;left:0;top:0;font-size:40px;z-index:999">Whoops</div><style>*{color:red!important}</style><script>debugger;</script> 2. Open inspector 3. Reload page to trigger the 'debugger' command and pause the execution What is the expected output? What do you see instead? The problem is that the 'Scripts' panel uses the data url as script name in 'Call Stack' panel and parses it as HTML - see screenshot for what happens in this case.
Attachments
Screenshot (99.77 KB, image/png)
2010-12-22 06:08 PST, Yury Semikhatsky 		no flags
Details
Patch (1.14 KB, patch)
2010-12-22 06:11 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-12-22 06:08:51 PST
Created attachment 77213 [details] Screenshot
Yury Semikhatsky
Comment 2 2010-12-22 06:09:25 PST
Original Chromium bug report: http://crbug.com/67781
Yury Semikhatsky
Comment 3 2010-12-22 06:11:35 PST
Created attachment 77214 [details] Patch
Joseph Pecoraro
Comment 4 2010-12-22 09:25:35 PST
Comment on attachment 77214 [details] Patch r=me, good fix. Should we audit any other uses of innerHTML in the inspector?
WebKit Commit Bot
Comment 5 2010-12-22 14:39:24 PST
Comment on attachment 77214 [details] Patch Clearing flags on attachment: 77214 Committed r74506: <http://trac.webkit.org/changeset/74506>
WebKit Commit Bot
Comment 6 2010-12-22 14:39:30 PST
All reviewed patches have been landed. Closing bug.
Yury Semikhatsky
Comment 7 2010-12-23 02:42:00 PST
At first glance in other places we set innerHTML to values constructed by ourselves in the front-end code but we may want to double check this. (In reply to comment #4) > (From update of attachment 77214 [details]) > r=me, good fix. Should we audit any other uses of innerHTML in the inspector?
Note You need to log in before you can comment on or make changes to this bug.