Bug 51458 – build failure: PluginViewGtk.cpp:65:23: fatal error: gdkconfig.h: No such file or directory

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Craig Keogh]

Building WebKit against gtk+ 3.0 (2.91.8) fails with:

In file included from WebCore/plugins/gtk/PluginViewGtk.cpp:43:0:
./WebCore/platform/gtk/GtkVersioning.h:34:0: warning: "GDK_DISPLAY" redefined
/opt/gnome/include/gtk-3.0/gdk/gdkdisplay.h:38:0: note: this is the location of the previous definition
WebCore/plugins/gtk/PluginViewGtk.cpp:65:23: fatal error: gdkconfig.h: No such file or directory
compilation terminated.

Replace:

#include <gdkconfig.h>

with:

#include <gdk/gdkconfig.h>

and build resumes.

[Wouter Bolsterlee]

No, the right fix is slightly different, as noted here:

http://mail.gnome.org/archives/desktop-devel-list/2010-December/msg00095.html

This is the patch:


diff --git a/WebCore/plugins/gtk/PluginViewGtk.cpp b/WebCore/plugins/gtk/PluginViewGtk.cpp
index 925ab79..adc0896 100644
--- a/WebCore/plugins/gtk/PluginViewGtk.cpp
+++ b/WebCore/plugins/gtk/PluginViewGtk.cpp
@@ -62,7 +62,7 @@
 #include <runtime/JSLock.h>
 #include <runtime/JSValue.h>
 
-#include <gdkconfig.h>
+#include <gdk/gdk.h>
 #include <gtk/gtk.h>
 
 #if defined(XP_UNIX)

[Wouter Bolsterlee]

... or remove the #include completely, since #include gtk/gtk.h is also there.

[Alexey Proskuryakov]

See also: bug 51472.

[Wouter Bolsterlee]

This bug should be closed as a duplicate of #51487, since that report includes the issue reported here.

[Xan Lopez]

This was fixed in http://trac.webkit.org/changeset/74496

[Xan Lopez]

*** Bug 51472 has been marked as a duplicate of this bug. ***