See summary.
Created attachment 77194 [details] Patch
See https://bugs.webkit.org/show_bug.cgi?id=49481#c70
Perhaps, I made the check too liberal by ignoring all _ in Objective C variables. Maybe it should only allow a single leading _. (If this is so, speak up and I believe I can adjust this.)
I believe only leading _ is allowed for AppKit style objc.
Comment on attachment 77194 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77194&action=review Looks good. I think it's OK to land this patch as is. If we want a stricter rule, we may be able to create another patch. > Tools/Scripts/webkitpy/style/checkers/cpp.py:933 > + self._is_objective_c = None I feel we want a comment here which describes we'll guess this value in is_objective_c.
Comment on attachment 77194 [details] Patch Landed as http://trac.webkit.org/changeset/74478. Agreed with Shinichiro that we can make the check more strict in another patch. (It will be nice to get rid of this false positive now and I suspect the issue of underscores in variables is a less common mistake for Objective C programmers.)