WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
51448
Support unprefixed box-shadow property
https://bugs.webkit.org/show_bug.cgi?id=51448
Summary
Support unprefixed box-shadow property
Simon Fraser (smfr)
Reported
2010-12-21 22:09:05 PST
We should support the unprefixed box-shadow property from CSS3 Borders and Backgrounds. Note that this will require some radius adjustment, since CG shadow radii are incorrect for radius > 8.
Attachments
Patch
(68.42 KB, patch)
2010-12-21 22:39 PST
,
Simon Fraser (smfr)
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2010-12-21 22:39:47 PST
Created
attachment 77190
[details]
Patch
Ariya Hidayat
Comment 2
2010-12-22 09:31:47 PST
Comment on
attachment 77190
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=77190&action=review
> WebCore/rendering/style/ShadowData.h:95 > + bool m_isWebkitBoxShadow;
Shouldn't it be m_isWebKitBoxShadow : 1 instead?
Simon Fraser (smfr)
Comment 3
2010-12-22 09:38:50 PST
(In reply to
comment #2
)
> Shouldn't it be m_isWebKitBoxShadow : 1 instead?
That would only be worth doing if we stuff ShadowStyle into the bitfield alongside it.
Simon Fraser (smfr)
Comment 4
2010-12-22 21:46:56 PST
http://trac.webkit.org/changeset/74538
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug