Bug 51448 - Support unprefixed box-shadow property
: Support unprefixed box-shadow property
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: CSS
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To: Simon Fraser (smfr)
:
Depends on:
Blocks: 51536
  Show dependency treegraph
 
Reported: 2010-12-21 22:09 PST by Simon Fraser (smfr)
Modified: 2010-12-23 06:24 PST (History)
2 users (show)

See Also:


Attachments
Patch (68.42 KB, patch)
2010-12-21 22:39 PST, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-12-21 22:09:05 PST
We should support the unprefixed box-shadow property from CSS3 Borders and Backgrounds.

Note that this will require some radius adjustment, since CG shadow radii are incorrect for radius > 8.
Comment 1 Simon Fraser (smfr) 2010-12-21 22:39:47 PST
Created attachment 77190 [details]
Patch
Comment 2 Ariya Hidayat 2010-12-22 09:31:47 PST
Comment on attachment 77190 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77190&action=review

> WebCore/rendering/style/ShadowData.h:95
> +    bool m_isWebkitBoxShadow;

Shouldn't it be m_isWebKitBoxShadow : 1 instead?
Comment 3 Simon Fraser (smfr) 2010-12-22 09:38:50 PST
(In reply to comment #2)
> Shouldn't it be m_isWebKitBoxShadow : 1 instead?

That would only be worth doing if we stuff ShadowStyle into the bitfield alongside it.
Comment 4 Simon Fraser (smfr) 2010-12-22 21:46:56 PST
http://trac.webkit.org/changeset/74538