Can't stop QT music on santastreefarm.com
<rdar://problem/8741152>
Created attachment 77174 [details] Patch
Comment on attachment 77174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77174&action=review > WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:773 > +static NPBool NPN_ConvertPoint(NPP npp, double sourceX, double sourceY, NPCoordinateSpace sourceSpace, double* destX, double* destY, NPCoordinateSpace destSpace) I hate the name npp! > WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:101 > + switch (sourceSpace) { Wow, are all these cases covered in testing? > WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:120 > + sourceYInScreenSpace = [[[NSScreen screens] objectAtIndex:0] frame].size.height - sourceY; Seems like we should use a helper function instead of repeating this twice. WebCore has a helper for this, but you could just use a local one.
Committed r74445: <http://trac.webkit.org/changeset/74445>