Bug 51437 – Add a way to get a web archive in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Darin Adler]

Add a way to get a web archive in WebKit2

[Darin Adler]

Created attachment 77173 [details]
Patch

[Brady Eidson]

Comment on attachment 77173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77173&action=review

> WebKit2/ChangeLog:15
> +        (WebKit::WebPageProxy::getWebArchiveForFrame): Added.

Not going to r- based on this, but consider it - I slightly prefer "getWebArchiveOfFrame" instead of "getWebArchiveForFrame"

Same comment applies throughout

> WebKit2/WebProcess/WebPage/WebPage.cpp:951
> +

It seems weird that every platform has this family of functionality even if they don't support our concept of a "WebArchive," and that makes this silent "never really do anything here" behavior puzzling to me for non-Mac/Win builds.

I don't know a good solution for this without a whole-lot-more #ifdef'ing

[Darin Adler]

(In reply to comment #2)
> I slightly prefer "getWebArchiveOfFrame" instead of "getWebArchiveForFrame"

I talked to Sam and we decided to do it your way.

> It seems weird that every platform has this family of functionality even if they don't support our concept of a "WebArchive," and that makes this silent "never really do anything here" behavior puzzling to me for non-Mac/Win builds.

I thought it through, and I think this is probably the best tradeoff. I don’t think more ifdefs would be helpful. Returning an empty archive on platforms that don’t support archives seems OK to me, but you could argue that we need to return an error instead or omit the function entirely.

[Darin Adler]

Committed r74494: <http://trac.webkit.org/changeset/74494>