WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
Bug 51434
RegExpCache holds on to too much executable memory.
https://bugs.webkit.org/show_bug.cgi?id=51434
Summary
RegExpCache holds on to too much executable memory.
Gavin Barraclough
Reported
2010-12-21 17:22:05 PST
RegExpCache may hold on to too much memory for three reasons: (1) Caching 256 RegExps might be too man, for some platforms. (2) The RegExpCache gives regular expressions a very different lifetime to JIT translations of JS code, but they share an ExecutableAllocator, and thus share ExecutablePools. This means the RegExpCache may end up keeping the JIT code for translations of JS code alive. (3) Regular expressions in the RegExpCache may be sharing ExecutablePools. If this is the case, rejecting a single RegExp object won't actually free up any memory. This means the cache holds onto complied regular expressions that it cannot vend.
Attachments
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2010-12-21 17:31:50 PST
Patch landed in
r74441
addresses the first two issues, but the third concern still needs to be addressed. The best resolution to this may be to remove the pooling of executable code, allow individual, arbitrary sized allocations.
WebKit Review Bot
Comment 2
2010-12-21 19:32:05 PST
http://trac.webkit.org/changeset/74441
might have broken GTK Linux 64-bit Debug
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug