Bug 51432 – [chromium] Render surfaces with empty content rects cause crashes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Vangelis Kokkevis]

RenderSurfaceChromium's that have a zero content rect don't have a texture associated with them.  In RenderSurfaceChromium::draw() we need to check for a NULL m_contentsTexture before trying to bind the texture and render the surface.

The crash can trivially be reproduced by going to:

www.boxee.tv

[Vangelis Kokkevis]

Created attachment 77180 [details]
Proposed patch

[Kenneth Russell]

Comment on attachment 77180 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77180&action=review

Looks fine. One small typo.

> LayoutTests/platform/chromium/compositing/empty-render-surface-crasher.html:27
> +<p>This page tests that an empty render surface does not crash as reporterd in <a href='https://bugs.webkit.org/show_bug.cgi?id=51432'>this bug</a>. Pass if this does not crash.</p>

Typo: reporterd -> reported

[Vangelis Kokkevis]

Committed r74484: <http://trac.webkit.org/changeset/74484>

[Vangelis Kokkevis]

(In reply to comment #2)
> (From update of attachment 77180 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77180&action=review
> 
> Looks fine. One small typo.
> 
> > LayoutTests/platform/chromium/compositing/empty-render-surface-crasher.html:27
> > +<p>This page tests that an empty render surface does not crash as reporterd in <a href='https://bugs.webkit.org/show_bug.cgi?id=51432'>this bug</a>. Pass if this does not crash.</p>
> 
> Typo: reporterd -> reported

Ooops! Thanks.  Fixed typo and landed.