Bug 51427 – [chromium] media/controls-styling layout tests need rebaselining

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Steve Lacey]

Rebaseline and re-enable media/controls-styling layout tests.

[Steve Lacey]

Created attachment 77162 [details]
Patch

[David Levin]

Comment on attachment 77162 [details]
Patch

Looks fine to me. I'll leave the cq+ t Andrew to do if it looks fine to him.

[Andrew Scherkus]

Comment on attachment 77162 [details]
Patch

looks good!!!

[WebKit Review Bot]

Comment on attachment 77162 [details]
Patch

Rejecting attachment 77162 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Andrew Scherkus]

whoops looks like I need to add my name to committers.py :\

[Andrew Scherkus]

Comment on attachment 77162 [details]
Patch

trying this again...

[WebKit Commit Bot]

Comment on attachment 77162 [details]
Patch

Rejecting attachment 77162 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 77162]" exit_code: 2
Last 500 characters of output:
pdating working directory
Processing patch 77162 from bug 51427.
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html

Full output: http://queues.webkit.org/results/7241108

[Steve Lacey]

Created attachment 77260 [details]
Patch

[Steve Lacey]

Was pretty sure I added a ChangeLog to the patch. Obviously not.

New patch uploaded... for your review. Only diff should be the addition of a ChangeLog.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 77260 [details]:

inspector/styles-disable-then-enable.html bug 51384 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 77260 [details]
Patch

Clearing flags on attachment: 77260

Committed r74509: <http://trac.webkit.org/changeset/74509>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.