Bug 51427 - [chromium] media/controls-styling layout tests need rebaselining
Summary: [chromium] media/controls-styling layout tests need rebaselining
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-21 14:58 PST by Steve Lacey
Modified: 2010-12-22 15:33 PST (History)
2 users (show)

See Also:


Attachments
Patch (249.18 KB, patch)
2010-12-21 16:05 PST, Steve Lacey
no flags Details | Formatted Diff | Diff
Patch (250.38 KB, patch)
2010-12-22 14:38 PST, Steve Lacey
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Lacey 2010-12-21 14:58:56 PST
Rebaseline and re-enable media/controls-styling layout tests.
Comment 1 Steve Lacey 2010-12-21 16:05:32 PST
Created attachment 77162 [details]
Patch
Comment 2 David Levin 2010-12-21 20:25:18 PST
Comment on attachment 77162 [details]
Patch

Looks fine to me. I'll leave the cq+ t Andrew to do if it looks fine to him.
Comment 3 Andrew Scherkus 2010-12-22 10:08:05 PST
Comment on attachment 77162 [details]
Patch

looks good!!!
Comment 4 WebKit Review Bot 2010-12-22 10:08:50 PST
Comment on attachment 77162 [details]
Patch

Rejecting attachment 77162 [details] from commit-queue.

scherkus@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 Andrew Scherkus 2010-12-22 10:11:11 PST
whoops looks like I need to add my name to committers.py :\
Comment 6 Andrew Scherkus 2010-12-22 11:53:17 PST
Comment on attachment 77162 [details]
Patch

trying this again...
Comment 7 WebKit Commit Bot 2010-12-22 14:20:45 PST
Comment on attachment 77162 [details]
Patch

Rejecting attachment 77162 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 77162]" exit_code: 2
Last 500 characters of output:
pdating working directory
Processing patch 77162 from bug 51427.
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html

Full output: http://queues.webkit.org/results/7241108
Comment 8 Steve Lacey 2010-12-22 14:38:52 PST
Created attachment 77260 [details]
Patch
Comment 9 Steve Lacey 2010-12-22 14:41:03 PST
Was pretty sure I added a ChangeLog to the patch. Obviously not.

New patch uploaded... for your review. Only diff should be the addition of a ChangeLog.
Comment 10 WebKit Commit Bot 2010-12-22 15:30:23 PST
The commit-queue encountered the following flaky tests while processing attachment 77260 [details]:

inspector/styles-disable-then-enable.html bug 51384 (author: pfeldman@chromium.org)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2010-12-22 15:32:58 PST
Comment on attachment 77260 [details]
Patch

Clearing flags on attachment: 77260

Committed r74509: <http://trac.webkit.org/changeset/74509>
Comment 12 WebKit Commit Bot 2010-12-22 15:33:05 PST
All reviewed patches have been landed.  Closing bug.