Bug 51423 - CopyTex{Sub}Image2D check always if the bound fbo's internal color format is compatible
Summary: CopyTex{Sub}Image2D check always if the bound fbo's internal color format is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-21 14:51 PST by Zhenyao Mo
Modified: 2010-12-22 13:05 PST (History)
3 users (show)

See Also:

Attachments
Patch (22.81 KB, patch)
2010-12-22 10:55 PST, Zhenyao Mo 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2010-12-21 14:51:00 PST 
Remove the isGLES2Compliant() flag.

Reasons:
1) It's really cheap to do this, and return error earlier is a plus. We track the internal format anyway. might just use it.
2) command buffer port has isGLES2Compliant() set to true, but it doesn't check the color format compatibility.
Comment 1 Zhenyao Mo 2010-12-22 10:55:23 PST 
Created attachment 77236 [details]
Patch
Comment 2 Zhenyao Mo 2010-12-22 10:55:49 PST 
The test is in sync with khronos.
Comment 3 Kenneth Russell 2010-12-22 11:54:19 PST 
Comment on attachment 77236 [details]
Patch

Looks good. Test case looks thorough.
Comment 4 Zhenyao Mo 2010-12-22 13:05:25 PST 
Committed r74497: <http://trac.webkit.org/changeset/74497>