Bug 51413 - REGRESSION (r71884): Returning alternate requests from willSendRequest can prevent other requests from ever being sent
Summary: REGRESSION (r71884): Returning alternate requests from willSendRequest can pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P1 Normal
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2010-12-21 12:08 PST by mitz
Modified: 2010-12-21 21:15 PST (History)
9 users (show)

See Also:


Attachments
Project showing the bug (5.53 KB, application/zip)
2010-12-21 12:08 PST, mitz
no flags Details
Call willSendRequest() before scheduling the request (6.57 KB, patch)
2010-12-21 18:29 PST, mitz
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2010-12-21 12:08:44 PST
Created attachment 77142 [details]
Project showing the bug

<rdar://problem/8668230>

To reproduce this bug, build and run the attached project. With r71883, the program reports that all requests will be sent, and finishes after logging “Frame load finished”. With r71884, it only reports the first seven requests and never finishes.
Comment 1 mitz 2010-12-21 16:31:36 PST
r71884 was wrong in moving willSendRequest to ResourceLoader::start(). It’s wrong to do all the scheduling, which is host-dependent, before calling willSendRequest, because the latter can change the host.
Comment 2 mitz 2010-12-21 16:31:55 PST
Unfortunately, it is not easy to revert r71884 because of later changes to the code.
Comment 3 mitz 2010-12-21 18:29:22 PST
Created attachment 77176 [details]
Call willSendRequest() before scheduling the request
Comment 4 mitz 2010-12-21 20:10:43 PST
Comment on attachment 77176 [details]
Call willSendRequest() before scheduling the request

Clearing flags on attachment: 77176

Committed r74453: <http://trac.webkit.org/changeset/74453>
Comment 5 mitz 2010-12-21 20:10:48 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-12-21 20:33:34 PST
http://trac.webkit.org/changeset/74453 might have broken Leopard Intel Release (Build), Leopard Intel Debug (Build), Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, Qt Windows 32-bit Release, and Qt Windows 32-bit Debug
Comment 7 Tony Gentilcore 2010-12-21 21:09:52 PST
Committed r74459: <http://trac.webkit.org/changeset/74459>
Comment 8 mitz 2010-12-21 21:11:52 PST
(In reply to comment #7)
> Committed r74459: <http://trac.webkit.org/changeset/74459>

I don’t think this is related to this bug.
Comment 9 Tony Gentilcore 2010-12-21 21:15:06 PST
(In reply to comment #8)
> (In reply to comment #7)
> > Committed r74459: <http://trac.webkit.org/changeset/74459>
> 
> I don’t think this is related to this bug.

No, I'm sorry. It belonged to https://bugs.webkit.org/show_bug.cgi?id=51445, but a ChangeLog merge error at commit time left my entry below the top :-(