RESOLVED FIXED 51394
[GTK] minimal build with --database fails 
https://bugs.webkit.org/show_bug.cgi?id=51394
Summary [GTK] minimal build with --database fails
Philippe Normand
Reported Tuesday, December 21, 2010 2:57:01 PM UTC
../../WebKit/gtk/webkit/webkitprivate.cpp: In function ‘void webkit_init()’: ../../WebKit/gtk/webkit/webkitprivate.cpp:137: error: ‘cacheStorage’ is not a member of ‘WebCore’ make[1]: *** [WebKit/gtk/webkit/libwebkitgtk_3_0_la-webkitprivate.lo] Error 1 cacheStorage usage there should be guarded with ENABLE(OFFLINE_WEB_APPLICATIONS) as in ApplicationCacheStorage.cpp where it is implemented.
Attachments
proposed patch (1.50 KB, patch)
2010-12-21 07:09 PST, Philippe Normand 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 Tuesday, December 21, 2010 3:09:59 PM UTC
Created attachment 77109 [details] proposed patch
Eric Seidel (no email)
Comment 2 Friday, December 24, 2010 3:30:37 AM UTC
Comment on attachment 77109 [details] proposed patch OK.
Eric Seidel (no email)
Comment 3 Friday, December 24, 2010 3:30:59 AM UTC
Does this need both DATABASE and OFFLINE_WEB_APPLICATIONS?
Philippe Normand
Comment 4 Friday, December 24, 2010 9:05:22 AM UTC
(In reply to comment #3) > Does this need both DATABASE and OFFLINE_WEB_APPLICATIONS? Right webkit_set_web_database indeed needs DATABASE. Will fix up and commit, thanks for the review Eric!
Philippe Normand
Comment 5 Friday, December 24, 2010 9:37:24 AM UTC
I'll guard the webkit_set_web_database_directory_path() call with ENABLE(DATABASE) and the cacheStorage() stuff with ENABLE(OFFLINE_WEB_APPLICATIONS)
Philippe Normand
Comment 6 Friday, December 24, 2010 9:40:55 AM UTC
(In reply to comment #5) > I'll guard the webkit_set_web_database_directory_path() call with ENABLE(DATABASE) and the cacheStorage() stuff with ENABLE(OFFLINE_WEB_APPLICATIONS) Oh well ENABLE(DATABASE) is already checked in webkit_set_web_database_directory_path() code, so in the end I don't think it's needed in webkitprivate.cpp
Philippe Normand
Comment 7 Friday, December 24, 2010 10:13:14 AM UTC
Committed r74620: <http://trac.webkit.org/changeset/74620>
Note You need to log in before you can comment on or make changes to this bug.