RESOLVED FIXED 51391
[v8] trunk/LayoutTests/fast/js/large-expressions.html fails since r74402 
https://bugs.webkit.org/show_bug.cgi?id=51391
Summary [v8] trunk/LayoutTests/fast/js/large-expressions.html fails since r74402
Andrei Popescu
Reported 2010-12-21 06:13:31 PST
In http://trac.webkit.org/changeset/74402/ Gavin Barraclough introduced changes in the way stack size is computed on a bunch of platforms. Since that change, the fast/js/large-expressions-expected.txt layout tests fails on Chromium: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/4498 Mads, is this something that affects V8? I will update our test expectations until we figure out a solution.
Attachments
Add attachment proposed patch, testcase, etc.
Mads Ager
Comment 1 2010-12-21 06:44:27 PST
We have a stack-size estimate in V8 and I believe the sandbox is currently blocking us from reading the actual stack size. Therefore we cannot follow this easily. Updating test expectations is the right thing for now.
Andrei Popescu
Comment 2 2010-12-21 06:54:52 PST
(In reply to comment #1) > We have a stack-size estimate in V8 and I believe the sandbox is currently blocking us from reading the actual stack size. Therefore we cannot follow this easily. Updating test expectations is the right thing for now.
Andrei Popescu
Comment 3 2010-12-21 06:55:18 PST
(In reply to comment #2) > (In reply to comment #1) > > We have a stack-size estimate in V8 and I believe the sandbox is currently blocking us from reading the actual stack size. Therefore we cannot follow this easily. Updating test expectations is the right thing for now. Thanks Mads, I will rebaseline the test and close this bug.
Andrei Popescu
Comment 4 2010-12-21 06:59:46 PST
Committed r74413
Note You need to log in before you can comment on or make changes to this bug.