Bug 51386 - For box-shadow, non-primary shadow should have specified radius
Summary: For box-shadow, non-primary shadow should have specified radius
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-21 01:17 PST by Hajime Morrita
Modified: 2010-12-26 20:42 PST (History)
2 users (show)

See Also:


Attachments
repro. (479 bytes, text/html)
2010-12-21 01:17 PST, Hajime Morrita
no flags Details
Patch (19.14 KB, patch)
2010-12-23 22:56 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (40.88 KB, patch)
2010-12-26 20:21 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (27.56 KB, patch)
2010-12-26 20:29 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (23.67 KB, patch)
2010-12-26 20:38 PST, Hajime Morrita
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2010-12-21 01:17:25 PST
Created attachment 77093 [details]
repro.

Reported at: http://habrahabr.ru/blogs/css/103170/

When multiple shadows are specified like
  -webkit-box-shadow: 110px -25px 0px -10px  #D8d8d8, 210px 15px 0px -15px #E0e0e0 , 310px -10px 0px -20px #E8e8e8, 410px 5px 0 -25px #F0f0f0, 510px 0px 0px -30px #F4f4f4;
the secondary shadow or later dont have rounded corner even if the source block has border-radius.
They should have rounded shadow.
Comment 1 Simon Fraser (smfr) 2010-12-21 20:15:07 PST
No, but now I've seen this, I'll fix it.
Comment 2 Simon Fraser (smfr) 2010-12-21 20:23:19 PST
This is essentially a dup of bug 49726. You're using negative spread values, and we don't preserve the radius in that case.

*** This bug has been marked as a duplicate of bug 49726 ***
Comment 3 Hajime Morrita 2010-12-21 20:35:58 PST
(In reply to comment #2)
> This is essentially a dup of bug 49726. You're using negative spread values, and we don't preserve the radius in that case.
Ah, I didn't notice that. Thanks for triaging.
Comment 4 Hajime Morrita 2010-12-23 22:18:41 PST
After some digging, I realized that this is a separate problem. 
A patch will come shortly.
Comment 5 Hajime Morrita 2010-12-23 22:56:39 PST
Created attachment 77404 [details]
Patch
Comment 6 Simon Fraser (smfr) 2010-12-24 08:39:38 PST
Please also add a tests for positive spread on a rectangle, and a rounded rectangle, with normal and inset shadows.
Comment 7 Simon Fraser (smfr) 2010-12-24 11:19:09 PST
Comment on attachment 77404 [details]
Patch

Please also add a tests for positive spread on a rectangle, and a rounded rectangle, with normal and inset shadows.
Comment 8 Hajime Morrita 2010-12-26 20:21:53 PST
Created attachment 77473 [details]
Patch
Comment 9 Hajime Morrita 2010-12-26 20:24:54 PST
Comment on attachment 77473 [details]
Patch

Attached a bad patch. cancelling....
Comment 10 Hajime Morrita 2010-12-26 20:29:06 PST
Created attachment 77474 [details]
Patch
Comment 11 mitz 2010-12-26 20:29:40 PST
Comment on attachment 77474 [details]
Patch

The test would be better if you removed the text. Then the results would be platform-independent and you could place them in the same directory with the test instead of in platform/mac.
Comment 12 Hajime Morrita 2010-12-26 20:38:15 PST
Created attachment 77475 [details]
Patch
Comment 13 Hajime Morrita 2010-12-26 20:42:20 PST
Committed r74673: <http://trac.webkit.org/changeset/74673>