Bug 51380 – [GTK] http/tests/inspector/console-websocket-error.html hangs

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKitGTK

[Yuta Kitamura]

The test http/tests/inspector/console-websocket-error.html hangs on the bot and seems to affect the following inspector tests. For now, I'll put this test into the Skipped list.

Test output:

CONSOLE MESSAGE: line 27: testDNSLookup: Test started.
CONSOLE MESSAGE: line 36: testDNSLookup: onclose is called.
CONSOLE MESSAGE: line 43: testSSLCertificate: Test started.
FAIL: Timed out waiting for notifyDone to be called
WebSocket's network errors should be logged to console.

[Yuta Kitamura]

Created attachment 77203 [details]
Patch

[Yuta Kitamura]

Hi Alexey, I'd like to update the test added in the recent "WebSocket network error to JS console" patch. Could you review this patch?

[WebKit Commit Bot]

Comment on attachment 77203 [details]
Patch

Rejecting attachment 77203 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--no-update', '--non-interactive', 77203]" exit_code: 2
Last 500 characters of output:
l
patching file LayoutTests/platform/gtk/Skipped
Hunk #1 FAILED at 5581.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej
patching file LayoutTests/platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt
patching file LayoutTests/platform/mac/http/tests/inspector/console-websocket-error-expected.txt

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Alexey Proskuryakov', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7286146

[Yuta Kitamura]

Committed r74611: <http://trac.webkit.org/changeset/74611>

[Yuta Kitamura]

Turned out that GTK bots still fail with this patch. :(

I will leave the changes to the test and revert only GTK's Skipped file, because this change improves the stability of this test regardless of GTK failure.

[WebKit Review Bot]

http://trac.webkit.org/changeset/74611 might have broken GTK Linux 64-bit Debug

[Yuta Kitamura]

Committed r74614: <http://trac.webkit.org/changeset/74614>

[Eric Seidel (no email)]

Should this be reopened?

[Takeshi Yoshino]

Skipped has been migrated to http://trac.webkit.org/browser/trunk/LayoutTests/platform/gtk/TestExpectations

This test is still suppressed.

[Brian Burg]

Test was removed.