Bug 51380 - [GTK] http/tests/inspector/console-websocket-error.html hangs
Summary: [GTK] http/tests/inspector/console-websocket-error.html hangs
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Yuta Kitamura
Depends on:
Reported: 2010-12-20 22:31 PST by Yuta Kitamura
Modified: 2014-12-17 17:09 PST (History)
7 users (show)

See Also:

Patch (6.54 KB, patch)
2010-12-22 04:39 PST, Yuta Kitamura
ap: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2010-12-20 22:31:33 PST
The test http/tests/inspector/console-websocket-error.html hangs on the bot and seems to affect the following inspector tests. For now, I'll put this test into the Skipped list.

Test output:

CONSOLE MESSAGE: line 27: testDNSLookup: Test started.
CONSOLE MESSAGE: line 36: testDNSLookup: onclose is called.
CONSOLE MESSAGE: line 43: testSSLCertificate: Test started.
FAIL: Timed out waiting for notifyDone to be called
WebSocket's network errors should be logged to console.
Comment 1 Yuta Kitamura 2010-12-22 04:39:29 PST
Created attachment 77203 [details]
Comment 2 Yuta Kitamura 2010-12-22 04:43:00 PST
Hi Alexey, I'd like to update the test added in the recent "WebSocket network error to JS console" patch. Could you review this patch?
Comment 3 WebKit Commit Bot 2010-12-23 20:33:05 PST
Comment on attachment 77203 [details]

Rejecting attachment 77203 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--no-update', '--non-interactive', 77203]" exit_code: 2
Last 500 characters of output:
patching file LayoutTests/platform/gtk/Skipped
Hunk #1 FAILED at 5581.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej
patching file LayoutTests/platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt
patching file LayoutTests/platform/mac/http/tests/inspector/console-websocket-error-expected.txt

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Alexey Proskuryakov', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7286146
Comment 4 Yuta Kitamura 2010-12-23 20:50:19 PST
Committed r74611: <http://trac.webkit.org/changeset/74611>
Comment 5 Yuta Kitamura 2010-12-23 21:55:31 PST
Turned out that GTK bots still fail with this patch. :(

I will leave the changes to the test and revert only GTK's Skipped file, because this change improves the stability of this test regardless of GTK failure.
Comment 6 WebKit Review Bot 2010-12-23 21:55:55 PST
http://trac.webkit.org/changeset/74611 might have broken GTK Linux 64-bit Debug
Comment 7 Yuta Kitamura 2010-12-23 22:05:32 PST
Committed r74614: <http://trac.webkit.org/changeset/74614>
Comment 8 Eric Seidel (no email) 2011-01-11 03:10:30 PST
Should this be reopened?
Comment 9 Takeshi Yoshino 2013-04-08 06:10:00 PDT
Skipped has been migrated to http://trac.webkit.org/browser/trunk/LayoutTests/platform/gtk/TestExpectations

This test is still suppressed.
Comment 10 Brian Burg 2014-12-17 17:09:42 PST
Test was removed.