Bug 51352 - Web process should only spin a run loop while waiting for replies to synchronous messages that invoke UI
Summary: Web process should only spin a run loop while waiting for replies to synchron...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, PlatformOnly
Depends on: 51351 53211
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-20 13:23 PST by Adam Roben (:aroben)
Modified: 2015-06-18 14:56 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-12-20 13:23:25 PST 
As described in bug 51351, having the UI process respond to synchronous messages from the web process on the main thread can result in deadlocks when windowed plugins are involved. We're going to move all synchronous message processing off the main thread by default in the UI process. But synchronous messages that result in needing to display UI (e.g., WebPageProxy::RunJavaScriptAlert) require doing so on the main thread. In those cases, the web process will need to spin a run loop while waiting for the message reply to avoid the kinds of deadlocks described in bug 51351.
Comment 1 Adam Roben (:aroben) 2010-12-20 13:25:05 PST 
<rdar://problem/8790537>
Comment 2 Adam Roben (:aroben) 2011-01-26 18:10:29 PST 
As described in bug 51351 comment 4, we're going to spin a run loop while waiting for a reply to all synchronous messages. Once bug 51351 is fixed we'll only spin a run loop while waiting for replies to synchronous messages that present UI in the UI process.
Comment 3 Adam Roben (:aroben) 2011-04-11 09:08:56 PDT 
(In reply to comment #2)
> As described in bug 51351 comment 4, we're going to spin a run loop while waiting for a reply to all synchronous messages.

Bug 58239 now covers this strategy.

> Once bug 51351 is fixed we'll only spin a run loop while waiting for replies to synchronous messages that present UI in the UI process.

We'll continue to use this bug to track this future improvement.
Comment 4 Anders Carlsson 2015-06-18 14:56:35 PDT 
We got rid of WK2 for Windows so this no longer applies.