Bug 51341 - [Qt] Set BUILDING_QT__ only once
Summary: [Qt] Set BUILDING_QT__ only once
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P4 Normal
Assignee: Nobody
Keywords: Qt, QtTriaged
Depends on:
Reported: 2010-12-20 11:26 PST by Laszlo Gombos
Modified: 2010-12-21 04:40 PST (History)
1 user (show)

See Also:

proposed patch (1.95 KB, patch)
2010-12-20 11:32 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-12-20 11:26:34 PST
Qt build system defines BUILDING_QT__ inconsistently. WebKit.pri sets it to 1, while WebKit2.pro only defines it without a value even though WebKit2.pro includes WebKit.pri. Some other "pro's" don't define it at all and they rely on WebKit.pri.
Comment 1 Laszlo Gombos 2010-12-20 11:32:12 PST
Created attachment 77015 [details]
proposed patch
Comment 2 Andreas Kling 2010-12-21 02:54:47 PST
Comment on attachment 77015 [details]
proposed patch

Comment 3 WebKit Commit Bot 2010-12-21 04:40:04 PST
Comment on attachment 77015 [details]
proposed patch

Clearing flags on attachment: 77015

Committed r74407: <http://trac.webkit.org/changeset/74407>
Comment 4 WebKit Commit Bot 2010-12-21 04:40:10 PST
All reviewed patches have been landed.  Closing bug.