Bug 51327 – [GTK] minimal build fails at link time due to missing sqlite3 symbols

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

WebCore/platform/sql/SQL* files should be included in the build only if the DATABASE feature is enabled. Especially SQLiteDatabase.cpp which is not guarded by that macro and includes sqlite3.h.

At configure time sqlite3 presence is checked only if one of the database-related features is enabled.

[Philippe Normand]

Created attachment 76989 [details]
proposed patch

[Xan Lopez]

Comment on attachment 76989 [details]
proposed patch

Any reason not to make the files have the proper guards?

[Philippe Normand]

(In reply to comment #2)
> (From update of attachment 76989 [details])
> Any reason not to make the files have the proper guards?

Well SQLiteDatabase is used in WebCore/page/GeolocationPositionCache.cpp, the appcache code, the icon database, WebCore/storage and probably more than git grep tells me. 

Now I think of another approach, what about keeping the GNUMakefile.am as it is and in configure.ac always check for sqlite3 presence. If it's not found and one or more features needing it are enabled, error out. If it's found and no features require it, platform/sql/SQL* will built anyway and not fail because the CFLAGS and LDFLAGS will be ok.

That'd be a less intrusive way to solve the problem, I believe.

[Philippe Normand]

Comment on attachment 76989 [details]
proposed patch

Will rework this

[Philippe Normand]

Created attachment 77611 [details]
proposed patch

[Martin Robinson]

Comment on attachment 77611 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77611&action=review

Thanks! Please fix some of these really minor issues before landing this.

> configure.ac:844
> +# check if sqlite 3 is available. Error out only if one of the

Please fix the capitalization here before landing. :)

> configure.ac:863
> +   AC_MSG_ERROR([SQLite3 is required to enable Database support])

For instance, if the error was due to missing SQLite and the feature was offline web applications, this message would be incorrect. Do you mind making it more general (or more specific with if-else blocks) before landing?

[Philippe Normand]

Thanks Martin, I made the error message more general.

Committed r74792: <http://trac.webkit.org/changeset/74792>

[Philippe Normand]

*** Bug 49208 has been marked as a duplicate of this bug. ***