Bug 51321 - [chromium] Optimize canvas.toDataURL("image/png") unpremultiplication loop
Summary: [chromium] Optimize canvas.toDataURL("image/png") unpremultiplication loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-20 01:00 PST by noel gordon
Modified: 2010-12-22 23:44 PST (History)
7 users (show)

See Also:

Attachments
patch (2.30 KB, patch)
2010-12-20 01:00 PST, noel gordon 		no flags Details | Formatted Diff | Diff
patch add bug title & url (2.42 KB, patch)
2010-12-20 15:37 PST, noel gordon 		no flags Details | Formatted Diff | Diff
patch change bug title (2.52 KB, patch)
2010-12-22 22:49 PST, noel gordon 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2010-12-20 01:00:36 PST 
Created attachment 76982 [details]
patch

The improvement is more modest than that achieved for the jpeg encoder on r73890
but I'm happy with a few percent.
Comment 1 WebKit Review Bot 2010-12-20 01:02:48 PST 
Attachment 76982 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp']" exit_code: 1
WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:55:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 noel gordon 2010-12-20 15:37:47 PST 
Created attachment 77045 [details]
patch add bug title & url
Comment 3 WebKit Review Bot 2010-12-20 15:39:03 PST 
Attachment 77045 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp']" exit_code: 1
WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:55:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 noel gordon 2010-12-22 22:49:03 PST 
Created attachment 77306 [details]
patch change bug title
Comment 5 WebKit Review Bot 2010-12-22 22:50:12 PST 
Attachment 77306 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp']" exit_code: 1
WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:55:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2010-12-22 23:43:57 PST 
Comment on attachment 77306 [details]
patch change bug title

Clearing flags on attachment: 77306

Committed r74540: <http://trac.webkit.org/changeset/74540>
Comment 7 WebKit Commit Bot 2010-12-22 23:44:05 PST 
All reviewed patches have been landed.  Closing bug.