RESOLVED FIXED51321
[chromium] Optimize canvas.toDataURL("image/png") unpremultiplication loop 
https://bugs.webkit.org/show_bug.cgi?id=51321
Summary [chromium] Optimize canvas.toDataURL("image/png") unpremultiplication loop
noel gordon
Reported 2010-12-20 01:00:36 PST
Created attachment 76982 [details] patch The improvement is more modest than that achieved for the jpeg encoder on r73890 but I'm happy with a few percent.
Attachments
patch (2.30 KB, patch)
2010-12-20 01:00 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
patch add bug title & url (2.42 KB, patch)
2010-12-20 15:37 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
patch change bug title (2.52 KB, patch)
2010-12-22 22:49 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2010-12-20 01:02:48 PST
Attachment 76982 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp']" exit_code: 1 WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:55: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
noel gordon
Comment 2 2010-12-20 15:37:47 PST
Created attachment 77045 [details] patch add bug title & url
WebKit Review Bot
Comment 3 2010-12-20 15:39:03 PST
Attachment 77045 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp']" exit_code: 1 WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:55: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
noel gordon
Comment 4 2010-12-22 22:49:03 PST
Created attachment 77306 [details] patch change bug title
WebKit Review Bot
Comment 5 2010-12-22 22:50:12 PST
Attachment 77306 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp']" exit_code: 1 WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:55: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 6 2010-12-22 23:43:57 PST
Comment on attachment 77306 [details] patch change bug title Clearing flags on attachment: 77306 Committed r74540: <http://trac.webkit.org/changeset/74540>
WebKit Commit Bot
Comment 7 2010-12-22 23:44:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.