Bug 51296 – [Qt] [WK2] Client are expected to render their own background for WebPages

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Benjamin Poulain]

Client are expected to render their own background for WebPages. This way, clients can choose to render something else than white background when the content is not available yet, for example, the checkerboard pattern as generally used.

[Benjamin Poulain]

Created attachment 76942 [details]
Patch

Kenneth, this is similar to the patch you made. There are the following differences:

-remove the call to painter->drawRect(area). This was only drawing 1px border, which is wrong in my opinion
-use QPainter::filerRect() instead of ::drawRect(). ::drawrect has to take into account the pen, ::fillRect is just a memfill in this case.

[Kenneth Rohde Christiansen]

Comment on attachment 76942 [details]
Patch

Looks good to me.

[Benjamin Poulain]

Created attachment 76945 [details]
Patch

Second part, this is directly taken from the patch of Kenneth.

[Benjamin Poulain]

Comment on attachment 76945 [details]
Patch

Removing cq?, I'll cq+ both patches together when this one is reviewed.

[Benjamin Poulain]

Note for the reviewer: TiledDrawingAreaProxy is only used by Qt at the moment.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 76942 [details]:

inspector/debugger-suspend-active-dom-objects.html bug 51301 (author: [e-mail])
The commit-queue is continuing to process your patch.

[Andreas Kling]

Comment on attachment 76945 [details]
Patch

r=me, nice to get rid of this.

[WebKit Commit Bot]

Comment on attachment 76945 [details]
Patch

Rejecting attachment 76945 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 76945]" exit_code: 2
Last 500 characters of output:
bexec/git-core/git-svn line 573


Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit2/ChangeLog
	M	WebKit2/UIProcess/TiledDrawingAreaProxy.cpp
	M	WebKit2/UIProcess/TiledDrawingAreaTile.h
	M	WebKit2/UIProcess/qt/TiledDrawingAreaTileQt.cpp
Merge conflict during commit: Conflict at '/trunk/WebKit2/ChangeLog' at /usr/local/git/libexec/git-core/git-svn line 573


Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1

Full output: http://queues.webkit.org/results/7276060

[WebKit Commit Bot]

Comment on attachment 76942 [details]
Patch

Clearing flags on attachment: 76942

Committed r74322: <http://trac.webkit.org/changeset/74322>

[Benjamin Poulain]

Comment on attachment 76945 [details]
Patch

Retrying. I don't see why the changelog conflicts. I'll commit manually if that fails.

[WebKit Commit Bot]

Comment on attachment 76945 [details]
Patch

Clearing flags on attachment: 76945

Committed r74324: <http://trac.webkit.org/changeset/74324>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.