Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
Created attachment 76922 [details]
Comment on attachment 76922 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=76922&action=review
> + No new tests. Current canvas layout tests sufficient.
If you're fixing a bug here, that's not true.
> -#define USE_IOSURFACE 1
> +#define WTF_USE_IOSURFACE 1
USE(IOSURFACE) is too vague when read out of context. It should be something like USE(IOSURFACE_CANVAS_BACKING_STORE) or something.
It's also rare, not not unknown, to #define a WTF macro outside of config.h
Created attachment 77240 [details]
(In reply to comment #2)
> (From update of attachment 76922 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76922&action=review
> > WebCore/ChangeLog:9
> > + No new tests. Current canvas layout tests sufficient.
> If you're fixing a bug here, that's not true.
Sorry, I should have pointed it out amongst all the similarly looking find-and-replace lines of the USE(IOSurface) renaming. This new patch has just the fix and I'll put the renaming in another patch.
Comment on attachment 77240 [details]
There is certainly a behavior change here, so it should be testable.
Created attachment 77275 [details]
Comment on attachment 77275 [details]
We don't tend to use interCaps for layout test files. Please rename it to accelerated-canvas-compositing.html
Also add a few words to the text file to say what is being tested.
Created attachment 77288 [details]
The commit-queue encountered the following flaky tests while processing attachment 77288 [details]:
fast/history/history-subframe-with-name.html bug 51039 (author: firstname.lastname@example.org)
The commit-queue is continuing to process your patch.
Comment on attachment 77288 [details]
Rejecting attachment 77288 [details] from commit-queue.
Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 77288]" exit_code: 2
Last 500 characters of output:
svnlook: Path 'trunk/LayoutTests/platform/mac-snowleopard/platform/mac/compositing/canvas' is not a file
The following files contain tab characters:
Please use spaces instead to indent.
If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
at /usr/local/git/libexec/git-core/git-svn line 573
Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Full output: http://queues.webkit.org/results/7307122
Committed r74570: <http://trac.webkit.org/changeset/74570>