Bug 51269 - Text area does not update when you arrow through a <select> in WebKit2
Summary: Text area does not update when you arrow through a <select> in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-12-17 12:06 PST by Brian Weinstein
Modified: 2010-12-17 13:09 PST (History)
3 users (show)

See Also:

Attachments
[PATCH] Fix (21.87 KB, patch)
2010-12-17 12:54 PST, Brian Weinstein 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2010-12-17 12:06:16 PST 
Text area does not update when you arrow through a <select> in WebKit2.

<rdar://problem/8612853>
Comment 1 Brian Weinstein 2010-12-17 12:54:35 PST 
Created attachment 76904 [details]
[PATCH] Fix
Comment 2 Anders Carlsson 2010-12-17 12:56:52 PST 
Comment on attachment 76904 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=76904&action=review

> WebKit2/UIProcess/WebPageProxy.h:104
> +class WebPageProxy : public APIObject, public WebPopupMenuProxy::Client {

Please remove public here.
Comment 3 Brian Weinstein 2010-12-17 13:05:36 PST 
(In reply to comment #2)
> (From update of attachment 76904 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76904&action=review
> 
> > WebKit2/UIProcess/WebPageProxy.h:104
> > +class WebPageProxy : public APIObject, public WebPopupMenuProxy::Client {
> 
> Please remove public here.

I get a compile error in WebView.cpp if I do :-(. I'll land this patch as-is + a change to UIProcess/qt/WebPopupMenuProxyQt.cpp
Comment 4 Brian Weinstein 2010-12-17 13:09:17 PST 
Landed in r74285.