Bug 51268 - [JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
Summary: [JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ariya Hidayat
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-17 12:05 PST by Ariya Hidayat
Modified: 2010-12-17 15:29 PST (History)
1 user (show)

See Also:


Attachments
[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST (1.07 KB, patch)
2010-12-17 12:06 PST, Ariya Hidayat
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ariya Hidayat 2010-12-17 12:05:25 PST
[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
Comment 1 Ariya Hidayat 2010-12-17 12:06:01 PST
Created attachment 76900 [details]
[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
Comment 2 Ariya Hidayat 2010-12-17 15:11:18 PST
With the patch, there won't be any difference in the code path for JSParser + SyntaxChecker. Currently, the flow will continue to execute createAssignment() function. With the patch, that is skipped all together.
Comment 3 Oliver Hunt 2010-12-17 15:12:32 PST
Comment on attachment 76900 [details]
[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST

r=me
Comment 4 Ariya Hidayat 2010-12-17 15:28:56 PST
Comment on attachment 76900 [details]
[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST

Clearing flags on attachment: 76900

Committed r74299: <http://trac.webkit.org/changeset/74299>
Comment 5 Ariya Hidayat 2010-12-17 15:29:05 PST
All reviewed patches have been landed.  Closing bug.