WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
51261
editing/execCommand/toggle-compound-styles-expected should use LayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=51261
Summary
editing/execCommand/toggle-compound-styles-expected should use LayoutTestCont...
Antonio Gomes
Reported
2010-12-17 09:00:41 PST
Test goes through platform specific editing behavior code path, so it should be tested using LayoutTestController::setEditingBehavior. That way we could get rid of platform specific test results. Right now we have: $ find LayoutTests/ -name toggle-compound-styles* (...) LayoutTests/platform/mac/editing/execCommand/toggle-compound-styles-expected.txt LayoutTests/platform/qt/editing/execCommand/toggle-compound-styles-expected.txt LayoutTests/platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt LayoutTests/platform/win/editing/execCommand/toggle-compound-styles-expected.txt
Attachments
fixes the test
(17.12 KB, patch)
2010-12-17 10:33 PST
,
Ryosuke Niwa
tonikitoo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antonio Gomes
Comment 1
2010-12-17 09:08:24 PST
Bug revealed by
bug 51163
Ryosuke Niwa
Comment 2
2010-12-17 10:33:53 PST
Created
attachment 76889
[details]
fixes the test
Ryosuke Niwa
Comment 3
2010-12-17 10:58:37 PST
Committed
r74279
: <
http://trac.webkit.org/changeset/74279
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug