Bug 51261 - editing/execCommand/toggle-compound-styles-expected should use LayoutTestController::setEditingBehavior
Summary: editing/execCommand/toggle-compound-styles-expected should use LayoutTestCont...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 51163
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-17 09:00 PST by Antonio Gomes
Modified: 2010-12-17 10:58 PST (History)
4 users (show)

See Also:


Attachments
fixes the test (17.12 KB, patch)
2010-12-17 10:33 PST, Ryosuke Niwa
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-12-17 09:00:41 PST
Test goes through platform specific editing behavior code path, so it should be tested using LayoutTestController::setEditingBehavior.

That way we could get rid of platform specific test results. Right now we have:

$ find LayoutTests/ -name toggle-compound-styles*
(...)
LayoutTests/platform/mac/editing/execCommand/toggle-compound-styles-expected.txt
LayoutTests/platform/qt/editing/execCommand/toggle-compound-styles-expected.txt
LayoutTests/platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt
LayoutTests/platform/win/editing/execCommand/toggle-compound-styles-expected.txt
Comment 1 Antonio Gomes 2010-12-17 09:08:24 PST
Bug revealed by bug 51163
Comment 2 Ryosuke Niwa 2010-12-17 10:33:53 PST
Created attachment 76889 [details]
fixes the test
Comment 3 Ryosuke Niwa 2010-12-17 10:58:37 PST
Committed r74279: <http://trac.webkit.org/changeset/74279>