Bug 51260 - Assertion failure with <select multiple required>
Summary: Assertion failure with <select multiple required>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-17 08:52 PST by Kent Tamura
Modified: 2010-12-26 22:35 PST (History)
5 users (show)

See Also:


Attachments
reproducing HTML (137 bytes, text/html)
2010-12-17 08:53 PST, Kent Tamura
no flags Details
Patch (4.71 KB, patch)
2010-12-21 22:05 PST, Dai Mikurube
no flags Details | Formatted Diff | Diff
Patch (4.68 KB, patch)
2010-12-21 22:52 PST, Dai Mikurube
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-12-17 08:52:43 PST
1. Open the attached HTML
2. Select either of options in the listbox
  - The :invalid style should be cleared, but :invalid is still applied.
3. click outside of the listbox
  Assertion failure occurs:
ASSERTION FAILED: m_isValid == validity()->valid()
(/Users/kent/WebKit/WebCore/html/HTMLFormControlElement.cpp:343 virtual bool WebCore::HTMLFormControlElement::isValidFormControlElement())
Comment 1 Kent Tamura 2010-12-17 08:53:38 PST
Created attachment 76885 [details]
reproducing HTML
Comment 3 Dai Mikurube 2010-12-21 22:05:52 PST
Created attachment 77188 [details]
Patch
Comment 4 Kent Tamura 2010-12-21 22:11:09 PST
Comment on attachment 77188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77188&action=review

> WebCore/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=51260
> +        Assertion failure with <select multiple required>

nit: We usually write a summary and a bug URL in this order.
Comment 5 Kent Tamura 2010-12-21 22:29:12 PST
Comment on attachment 77188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77188&action=review

> LayoutTests/fast/css/pseudo-valid-select-click.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

Can you merge this test into fast/forms/select-live-pseudo-selectors.html?
Comment 6 Dai Mikurube 2010-12-21 22:52:10 PST
Created attachment 77191 [details]
Patch
Comment 7 Dai Mikurube 2010-12-21 22:52:35 PST
(In reply to comment #5)
Ok, merged.
Comment 8 Kent Tamura 2010-12-21 22:54:27 PST
Comment on attachment 77191 [details]
Patch

ok
Comment 9 WebKit Commit Bot 2010-12-22 00:38:00 PST
Comment on attachment 77191 [details]
Patch

Clearing flags on attachment: 77191

Committed r74466: <http://trac.webkit.org/changeset/74466>
Comment 10 WebKit Commit Bot 2010-12-22 00:38:08 PST
Comment on attachment 77191 [details]
Patch

Rejecting attachment 77191 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 77191]" exit_code: 1
Last 500 characters of output:
ebkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 546, in __getattr__
    self.forms()
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 559, in forms
    self._forms_factory.forms())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 228, in forms
    raise ParseError(exc)
webkitpy.thirdparty.autoinstalled.mechanize._html.ParseError

Full output: http://queues.webkit.org/results/7316102
Comment 11 Dai Mikurube 2010-12-26 21:37:56 PST
(In reply to comment #10)
Does anyone know the current status?
The patch looks committed into the tree, and it can be built correctly despite this error in applying the patch.
Comment 12 Alexey Proskuryakov 2010-12-26 21:50:10 PST
Looks like commit queue failed to close the bug.
Comment 13 Adam Barth 2010-12-26 21:55:15 PST
(In reply to comment #12)
> Looks like commit queue failed to close the bug.

Strange.  We should look at the logs to see what happened.
Comment 14 Dai Mikurube 2010-12-26 22:01:04 PST
(In reply to comment #13)
Alexey, Adam,
Thank you for handling it. In addition, a similar error happened in the bug 51289.
Comment 15 Eric Seidel (no email) 2010-12-26 22:35:29 PST
Sound like bug 33659.