Bug 51243 - Web Inspector: can't set breakpoints if resource content is loaded too fast
Summary: Web Inspector: can't set breakpoints if resource content is loaded too fast
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-17 04:20 PST by Pavel Podivilov
Modified: 2010-12-17 06:48 PST (History)
10 users (show)

See Also:

Attachments
Patch. (4.31 KB, patch)
2010-12-17 04:21 PST, Pavel Podivilov 		pfeldman: review-
Details | Formatted Diff | Diff
Patch. (1.99 KB, patch)
2010-12-17 05:09 PST, Pavel Podivilov 		pfeldman: review-
Details | Formatted Diff | Diff
Patch. (1.97 KB, patch)
2010-12-17 06:45 PST, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-12-17 04:20:25 PST 
Currently if resource content is loaded too fast, SourceFrame doesn't get all the scripts, so SourceFrame should listen for parsed script events itself.
Comment 1 Pavel Podivilov 2010-12-17 04:21:22 PST 
Created attachment 76865 [details]
Patch.
Comment 2 Pavel Feldman 2010-12-17 04:32:48 PST 
Comment on attachment 76865 [details]
Patch.

I don't think SourceFrame should listen to parsed script events.
Comment 3 Pavel Podivilov 2010-12-17 05:09:34 PST 
Created attachment 76870 [details]
Patch.

Add scripts parsed after resource load to SourceFrame.
Comment 4 Pavel Feldman 2010-12-17 06:19:13 PST 
Comment on attachment 76870 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=76870&action=review

> WebCore/inspector/front-end/ScriptsPanel.js:259
> +                var view = WebInspector.ResourceManager.resourceViewForResource(resource);

You should use WebInspector.ResourceManager.existingResourceViewForResource not to create it unless necessary.
Comment 5 Pavel Podivilov 2010-12-17 06:45:14 PST 
Created attachment 76875 [details]
Patch.
Comment 6 Pavel Podivilov 2010-12-17 06:48:13 PST 
Committed r74261: <http://trac.webkit.org/changeset/74261>