Bug 51237 - [chromium] canvas.toDataURL("image/jpeg") should composite onto black
Summary: [chromium] canvas.toDataURL("image/jpeg") should composite onto black
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 67402
  Show dependency tree / graph
 
Reported: 2010-12-17 00:50 PST by noel gordon
Modified: 2011-09-07 05:02 PDT (History)
8 users (show)

See Also:

Attachments
patch (2.82 KB, patch)
2010-12-17 00:59 PST, noel gordon 		no flags Details | Formatted Diff | Diff
patch (3.01 KB, patch)
2010-12-17 01:32 PST, noel gordon 		no flags Details | Formatted Diff | Diff
patch update changelog description (3.03 KB, patch)
2010-12-19 17:14 PST, noel gordon 		no flags Details | Formatted Diff | Diff
patch update test_expectations.txt (4.51 KB, patch)
2010-12-19 22:45 PST, noel gordon 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2010-12-17 00:50:33 PST 
[chromium] canvas.toDataURL("image/jpeg") composite onto black
Comment 1 noel gordon 2010-12-17 00:59:51 PST 
Created attachment 76855 [details]
patch
Comment 2 Eric Seidel (no email) 2010-12-17 01:02:13 PST 
Comment on attachment 76855 [details]
patch

Doesn't this need to include pixel test updates and or test_expectations.txt updates?
Comment 3 Eric Seidel (no email) 2010-12-17 01:02:30 PST 
Oliver knows way more about canvas than I do.
Comment 4 noel gordon 2010-12-17 01:08:59 PST 
> Oliver knows way more about canvas than I do.

No worries, that's why I added Stephen. Bear with me a moment while I update another patch.
Comment 5 noel gordon 2010-12-17 01:32:42 PST 
Created attachment 76858 [details]
patch
Comment 6 noel gordon 2010-12-19 17:14:10 PST 
Created attachment 76964 [details]
patch update changelog description
Comment 7 noel gordon 2010-12-19 22:43:54 PST 
(In reply to comment #2)
> Doesn't this need to include pixel test updates and or test_expectations.txt updates?

yes, added test_expectations.txt update.
Comment 8 noel gordon 2010-12-19 22:45:20 PST 
Created attachment 76977 [details]
patch update test_expectations.txt
Comment 9 James Robinson 2010-12-30 20:36:52 PST 
Comment on attachment 76977 [details]
patch update test_expectations.txt

Looks good to me.
Comment 10 WebKit Commit Bot 2011-01-11 04:46:24 PST 
Comment on attachment 76977 [details]
patch update test_expectations.txt

Clearing flags on attachment: 76977

Committed r75488: <http://trac.webkit.org/changeset/75488>
Comment 11 WebKit Commit Bot 2011-01-11 04:46:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 noel gordon 2011-01-11 17:23:08 PST 
resolved http://www.w3.org/Bugs/Public/show_bug.cgi?id=11431 WONTFIX