RESOLVED FIXED Bug 51233
[Qt] Default image interpolation should reset the render hint 
https://bugs.webkit.org/show_bug.cgi?id=51233
Summary [Qt] Default image interpolation should reset the render hint
Ariya Hidayat
Reported 2010-12-16 22:50:43 PST
Setting image interpolation quality to 'default' sets the SmoothPixmapTransform render hint. This breaks the low-quality painting logic in GraphicsContext::drawImage. The reason is because the logic involves the steps: save current image interpolation quality, set the quality to low, draw the image, revert back the quality to the original. Thus, default must serve as a way to reset the render hint (to the original), otherwise the SmoothPixmapTransform render hint will be set forever.
Attachments
[Qt] Default image interpolation should reset the render hint (2.76 KB, patch)
2010-12-16 23:36 PST, Ariya Hidayat 		no flags
DetailsFormatted DiffDiff
[Qt] Default image interpolation should reset the render hint (2.76 KB, patch)
2010-12-17 00:00 PST, Ariya Hidayat 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ariya Hidayat
Comment 1 2010-12-16 23:36:37 PST
Created attachment 76849 [details] [Qt] Default image interpolation should reset the render hint
Early Warning System Bot
Comment 2 2010-12-16 23:47:35 PST
Attachment 76849 [details] did not build on qt: Build output: http://queues.webkit.org/results/7255006
Ariya Hidayat
Comment 3 2010-12-17 00:00:51 PST
Created attachment 76851 [details] [Qt] Default image interpolation should reset the render hint
Andreas Kling
Comment 4 2010-12-17 02:53:01 PST
Comment on attachment 76851 [details] [Qt] Default image interpolation should reset the render hint Thanks for fixing this! r=me
Ariya Hidayat
Comment 5 2010-12-17 08:43:14 PST
Comment on attachment 76851 [details] [Qt] Default image interpolation should reset the render hint Clearing flags on attachment: 76851 Committed r74272: <http://trac.webkit.org/changeset/74272>
Ariya Hidayat
Comment 6 2010-12-17 08:43:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.