Bug 51231 – document.querySelector(':nth-child(foo)') should throw a syntax error

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[temp01]

See http://code.google.com/p/chromium/issues/detail?id=67256

document.querySelector(':nth-child(foo)') should throw a SYNTAX_ERR DOM Exception like document.querySelector(':nth-child(2foo)') does -- but instead, it just returns null and moves on.

[Yael]

Created attachment 78110 [details]
Patch

Add a check in the parser that nth selectors can only accept an+b, odd or even as parameters.

[Darin Adler]

Comment on attachment 78110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78110&action=review

> WebCore/css/CSSGrammar.y:1212
> +            }
> +            else

WebKit project style is to put the else on the same line as the close brace.

> WebCore/css/CSSParser.h:82
> +        bool isValidNthToken(const CSSParserString&);

This should be a static member function. There is no dependency here on the parser state, so no need for a non-static member function.

[Yael]

Committed r75158 <http://trac.webkit.org/changeset/75158>.