Bug 51199 - Add tests for UTF-16 decoding and its variants
Summary: Add tests for UTF-16 decoding and its variants
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
Depends on:
Reported: 2010-12-16 10:59 PST by Yong Li
Modified: 2010-12-16 18:29 PST (History)
2 users (show)

See Also:

the patch (4.38 KB, patch)
2010-12-16 11:42 PST, Yong Li
ap: review+
yong.li.webkit: commit-queue-
Details | Formatted Diff | Diff
added comments (4.52 KB, patch)
2010-12-16 12:33 PST, Yong Li
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2010-12-16 10:59:28 PST
51035 is closed as invalid. But the tests are good to have.
Comment 1 Yong Li 2010-12-16 11:42:45 PST
Created attachment 76794 [details]
the patch
Comment 2 Alexey Proskuryakov 2010-12-16 11:54:55 PST
Comment on attachment 76794 [details]
the patch

Thank you!

Please consider adding an explanation of expected results as a comment in the test (something like "According to HTML5 and for IE compatibility, UTF-16 is treated as little endian. These subtest fail as of Firefox 3.6.13.")

To mention that the test fail in Firefox, you'll need to separate those that actually do (UTF-16LE  and unicodeFEFF should obviously pass everywhere).
Comment 3 Yong Li 2010-12-16 12:33:54 PST
Created attachment 76801 [details]
added comments
Comment 4 WebKit Commit Bot 2010-12-16 18:29:01 PST
Comment on attachment 76801 [details]
added comments

Clearing flags on attachment: 76801

Committed r74225: <http://trac.webkit.org/changeset/74225>
Comment 5 WebKit Commit Bot 2010-12-16 18:29:06 PST
All reviewed patches have been landed.  Closing bug.