Bug 51189 - Web Inspector: Console always scroll to the bottom on new events
Summary: Web Inspector: Console always scroll to the bottom on new events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-16 07:56 PST by Yury Semikhatsky
Modified: 2010-12-16 15:39 PST (History)
15 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2010-12-16 08:01 PST, Yury Semikhatsky 		timothy: review+
Details | Formatted Diff | Diff
Patch (3.31 KB, patch)
2010-12-16 08:39 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-12-16 07:56:01 PST 
Console should not scroll to the bottom while scrolled up.
Comment 1 Yury Semikhatsky 2010-12-16 08:01:02 PST 
Created attachment 76769 [details]
Patch
Comment 2 Pavel Feldman 2010-12-16 08:29:25 PST 
Comment on attachment 76769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76769&action=review

> WebCore/inspector/front-end/ConsoleView.js:215
> +    _isScrolledToLastMessage: function()

Can we define this on Element.prototype instead and reuse in DataGrid?
Comment 3 Yury Semikhatsky 2010-12-16 08:39:56 PST 
Created attachment 76772 [details]
Patch
Comment 4 Yury Semikhatsky 2010-12-16 08:40:42 PST 
Done.
(In reply to comment #2)
> (From update of attachment 76769 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76769&action=review
> 
> > WebCore/inspector/front-end/ConsoleView.js:215
> > +    _isScrolledToLastMessage: function()
> 
> Can we define this on Element.prototype instead and reuse in DataGrid?
Comment 5 Yury Semikhatsky 2010-12-16 08:57:16 PST 
Comment on attachment 76772 [details]
Patch

Clearing flags on attachment: 76772

Committed r74193: <http://trac.webkit.org/changeset/74193>
Comment 6 Yury Semikhatsky 2010-12-16 08:57:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-12-16 15:39:07 PST 
http://trac.webkit.org/changeset/74193 might have broken Leopard Intel Debug (Tests)