Bug 51184 - Web Inspector: remove unnecessary dependencies from InspectorBackendStub
Summary: Web Inspector: remove unnecessary dependencies from InspectorBackendStub
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
Depends on:
Reported: 2010-12-16 05:58 PST by Ilya Tikhonovsky
Modified: 2010-12-17 01:24 PST (History)
11 users (show)

See Also:

[patch] first iteration. (8.42 KB, patch)
2010-12-16 06:04 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-12-16 05:58:43 PST
InspectorBackendStub is a transport-only thing but it has dependencies with Callback.js and WebInspector namespace.
Callback can be integrated into InspectorBackendStub because it is the only client.

Without these dependencies InspectorBackendStub can be used as an API wrapper for Inspector Protocol.
Comment 1 Ilya Tikhonovsky 2010-12-16 06:04:13 PST
Created attachment 76763 [details]
[patch] first iteration.
Comment 2 Ilya Tikhonovsky 2010-12-17 00:30:06 PST
Comment on attachment 76763 [details]
[patch] first iteration.

Clearing flags on attachment: 76763

Committed r74236: <http://trac.webkit.org/changeset/74236>
Comment 3 Ilya Tikhonovsky 2010-12-17 00:30:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2010-12-17 01:24:22 PST
The commit-queue encountered the following flaky tests while processing attachment 76763 [details]:

http/tests/misc/redirect.php bug 51238 (author: mjs@apple.com)
inspector/styles-new-API.html bug 50889 (authors: apavlov@chromium.org and pfeldman@chromium.org)
The commit-queue is continuing to process your patch.