Bug 51175 – WebInspector: introduce DebuggerPresentationModel - model for all presentation data related to scripts panel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

WebInspector: introduce DebuggerPresentationModel - model for all presentation data related to scripts panel

[Pavel Podivilov]

Created attachment 76749 [details]
Patch.

This patch adds script beautification data and functions to DebuggerPresentationModel.
Later we should move all data used by ScriptsPanel and its views to DebuggerPresentationModel:
- JavaScript compilation errors and exceptions (used by SourceFrame to show message bubbles)
- lazy script and resource loading, mapping between scripts and resources
- other data used by views which is not a part of "real" debugger model (e.g. currently selected call frame index)

[Pavel Feldman]

Comment on attachment 76749 [details]
Patch.

As we discussed offline, there is no clear need in this separate abstraction.

[Pavel Podivilov]

We should add a layer between DebuggerModel and scripts panel ui classes to encapsulate complex logic such as source mapping, content loading, renames, scripts concatenation, etc.

New layer will receive events from DebuggerModel, map source locations and names and dispatch new events which are directly usable by ui.

This should be done in two steps:

1. Move source mapping logic and direct calls to DebuggerModel from SourceFrame to ScriptsPanel.
  1.1 Update SourceFrame decorations with direct calls from ScriptsPanel.
  1.2 Extract calls to DebuggerModel functions to a delegate class that is set up by the ScriptsPanel.
2. Extract source mapping and direct calls to DebuggerModel to a new DebuggerPresentationModel class, make ScriptsPanel DebuggerPresentationModel's listener.