Bug 51174 – Web Inspector: status message isn't shown in call stack sidebar pane for native breakpoints

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: status message isn't shown in call stack sidebar pane for native breakpoints

[Pavel Podivilov]

Created attachment 76748 [details]
Patch.

Update CallStackSidebarPane placards and status message in the same event handler so it doesn't depend on event dispatch order.

[Yury Semikhatsky]

Comment on attachment 76748 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=76748&action=review

> WebCore/inspector/front-end/BreakpointManager.js:181
> +        this._lastHitBreakpointView = breakpointView;

Breakpoint manager shouldn't modify breakpoint views, instead each view should listen to the corresponding breakpoint state changes and update itself. BreakpointManager should operate on the breakpoints. r- for this.

[Pavel Podivilov]

(In reply to comment #2)
> (From update of attachment 76748 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76748&action=review
> 
> > WebCore/inspector/front-end/BreakpointManager.js:181
> > +        this._lastHitBreakpointView = breakpointView;
> 
> Breakpoint manager shouldn't modify breakpoint views, instead each view should listen to the corresponding breakpoint state changes and update itself. BreakpointManager should operate on the breakpoints. r- for this.

This patch is just a quick fix, relations between BreakpointManager and breakpoint views didn't change. I've just renamed _lastHitBreakpoint.view to _lastHitBreakpointView.

Let me decouple breakpoint views from breakpoint manager in a separate patch.

[Pavel Podivilov]

Committed r74191: <http://trac.webkit.org/changeset/74191>

[WebKit Review Bot]

http://trac.webkit.org/changeset/74191 might have broken Leopard Intel Debug (Tests)