WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
51174
Web Inspector: status message isn't shown in call stack sidebar pane for native breakpoints
https://bugs.webkit.org/show_bug.cgi?id=51174
Summary
Web Inspector: status message isn't shown in call stack sidebar pane for nati...
Pavel Podivilov
Reported
2010-12-16 03:16:42 PST
Web Inspector: status message isn't shown in call stack sidebar pane for native breakpoints
Attachments
Patch.
(8.65 KB, patch)
2010-12-16 03:18 PST
,
Pavel Podivilov
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Podivilov
Comment 1
2010-12-16 03:18:29 PST
Created
attachment 76748
[details]
Patch. Update CallStackSidebarPane placards and status message in the same event handler so it doesn't depend on event dispatch order.
Yury Semikhatsky
Comment 2
2010-12-16 06:05:39 PST
Comment on
attachment 76748
[details]
Patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=76748&action=review
> WebCore/inspector/front-end/BreakpointManager.js:181 > + this._lastHitBreakpointView = breakpointView;
Breakpoint manager shouldn't modify breakpoint views, instead each view should listen to the corresponding breakpoint state changes and update itself. BreakpointManager should operate on the breakpoints. r- for this.
Pavel Podivilov
Comment 3
2010-12-16 06:40:43 PST
(In reply to
comment #2
)
> (From update of
attachment 76748
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=76748&action=review
> > > WebCore/inspector/front-end/BreakpointManager.js:181 > > + this._lastHitBreakpointView = breakpointView; > > Breakpoint manager shouldn't modify breakpoint views, instead each view should listen to the corresponding breakpoint state changes and update itself. BreakpointManager should operate on the breakpoints. r- for this.
This patch is just a quick fix, relations between BreakpointManager and breakpoint views didn't change. I've just renamed _lastHitBreakpoint.view to _lastHitBreakpointView. Let me decouple breakpoint views from breakpoint manager in a separate patch.
Pavel Podivilov
Comment 4
2010-12-16 07:58:26 PST
Committed
r74191
: <
http://trac.webkit.org/changeset/74191
>
WebKit Review Bot
Comment 5
2010-12-16 15:38:56 PST
http://trac.webkit.org/changeset/74191
might have broken Leopard Intel Debug (Tests)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug