Bug 51169 - [Qt][S60] Vertical borders of buttons and frames are misaligned
Summary: [Qt][S60] Vertical borders of buttons and frames are misaligned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P2 Critical
Assignee: Janne Koskinen
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-12-15 23:42 PST by varun
Modified: 2011-02-14 12:10 PST (History)
10 users (show)

See Also:


Attachments
Screenshots (87.62 KB, application/x-zip-compressed)
2010-12-15 23:42 PST, varun
no flags Details
patch for QtWebkit2.1 branch (1.81 KB, patch)
2011-02-10 09:41 PST, Janne Koskinen
no flags Details | Formatted Diff | Diff
Patch proposal for trunk (1.84 KB, patch)
2011-02-10 10:24 PST, Janne Koskinen
no flags Details | Formatted Diff | Diff
patch proposal for trunk - changelog fixed (1.81 KB, patch)
2011-02-11 00:40 PST, Janne Koskinen
no flags Details | Formatted Diff | Diff
patch for QtWebkit2.1 branch - log fixed (1.78 KB, patch)
2011-02-11 01:22 PST, Janne Koskinen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description varun 2010-12-15 23:42:40 PST
Created attachment 76739 [details]
Screenshots

Most buttons, panels, and frames are rendering incorrectly. The vertical sides of the elements are not lining up with the corners.
The vertical borders shift 1px to right for all elements, including the list panel.
See the attached screen shots.


Steps to reproduce the issue for a simple button:
------------------------
<html><body>
<input type="button" value="Border Test Button"/>
</body><html>
------------------------
1. Save above html code in a file (say "e:/a.html").
2. Open QtTestBrowser.
3. Enter "e:/a.html" in the address bar and press refresh button.

Actual Result:
HTML page with a button is displayed. Border of the button is not aligned properly.

Additional Info:
Qt - 4.7
QtWebkit - 2.1
OS - Sumbian^3
Issue has been moved from wrt team Boston defect 7315.
Comment 1 Prasad 2011-01-06 13:11:36 PST
Related QtWRT Bugzilla error ID: http://bugs.nokia-boston.com/bugzilla/show_bug.cgi?id=7315
Comment 2 Suresh Voruganti 2011-01-07 06:30:44 PST
Fix required for Qtwebkit 2.2
Comment 3 Benjamin Poulain 2011-01-28 17:39:21 PST
Please follow http://trac.webkit.org/wiki/QtWebKitBugs when reporing bug here (missing the keyword Qt).

(In reply to comment #2)
> Fix required for Qtwebkit 2.2

Is this seriously a blocker for 2.1.x? Are you sure it is a bug in WebKit at all? I would think this is part of common code and the bug is in Qt.
Comment 4 Janne Koskinen 2011-01-31 02:12:33 PST
> Is this seriously a blocker for 2.1.x? Are you sure it is a bug in WebKit at all? I would think this is part of common code and the bug is in Qt.

This issue happens with mobile webkit style only if OpenVG backend is used, raster engine is fine. AFAIK Qt buttons don't have this issue.
Comment 5 kasthuri 2011-01-31 11:26:38 PST
I spent some time on this issue.  It seems to happen only with Qt mobile theme enabled as Janne has pointed out.  If we disable Qt mobile style, then everything seems to be ok. I think the themeQtMobile.css is not liked by symbian.
Comment 6 Benjamin Poulain 2011-01-31 11:30:36 PST
(In reply to comment #5)
> I spent some time on this issue.  It seems to happen only with Qt mobile theme enabled as Janne has pointed out.  If we disable Qt mobile style, then everything seems to be ok. I think the themeQtMobile.css is not liked by symbian.

That already some info...
Maybe a property used by the theme is not well supported on Symbian.

Have you tried with the raster graphic system and the mobile theme?
Comment 7 kasthuri 2011-01-31 12:13:55 PST
(In reply to comment #6)
> (In reply to comment #5)
> > I spent some time on this issue.  It seems to happen only with Qt mobile theme enabled as Janne has pointed out.  If we disable Qt mobile style, then everything seems to be ok. I think the themeQtMobile.css is not liked by symbian.
> That already some info...
> Maybe a property used by the theme is not well supported on Symbian.
> Have you tried with the raster graphic system and the mobile theme?

Raster graphic system is working fine.
Comment 8 Benjamin Poulain 2011-01-31 12:22:10 PST
(In reply to comment #7)
> Raster graphic system is working fine.

Could you make a reduction? That way you could create a bug for Qt and close the bug here.
Comment 9 Janne Koskinen 2011-02-09 00:53:08 PST
This is actually bug/feature in the OpenVG hardware. Unfortunately we need to workaround this in QtWebkit. I'm preparing a patch.
Comment 10 Janne Koskinen 2011-02-10 09:41:51 PST
Created attachment 81994 [details]
patch for QtWebkit2.1 branch

OpenVG backend cannot guarantee pixel rendering to be correct in non-integer boundaries unless antialising is used.
Patch checks if the backend is OpenVg and forces lines to be drawn.
Comment 11 Suresh Voruganti 2011-02-10 09:44:01 PST
Adding to Qtwebkit 2.1 Master bug for cherry picking the fix to Qtwebkit 2.1
Comment 12 Janne Koskinen 2011-02-10 09:45:44 PST
(In reply to comment #10)
> Patch checks if the backend is OpenVg and forces lines to be drawn
antialiased.

Getting late again :)
Comment 13 Janne Koskinen 2011-02-10 10:24:12 PST
Created attachment 81998 [details]
Patch proposal for trunk

There is no layout test for this as it would require pixel per pixel analysis of render.
Comment 14 Benjamin Poulain 2011-02-10 10:55:10 PST
Comment on attachment 81998 [details]
Patch proposal for trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=81998&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests. (OOPS!)

You should remove that line.
Comment 15 Laszlo Gombos 2011-02-10 19:56:28 PST
Looks good to me, please fix ChangeLog.
Comment 16 Janne Koskinen 2011-02-11 00:40:15 PST
Created attachment 82112 [details]
patch proposal for trunk - changelog fixed
Comment 17 Janne Koskinen 2011-02-11 01:22:52 PST
Created attachment 82114 [details]
patch for QtWebkit2.1 branch - log fixed
Comment 18 Andreas Kling 2011-02-11 02:48:34 PST
Comment on attachment 82112 [details]
patch proposal for trunk - changelog fixed

r=me
Comment 19 WebKit Commit Bot 2011-02-11 05:19:49 PST
Comment on attachment 82112 [details]
patch proposal for trunk - changelog fixed

Clearing flags on attachment: 82112

Committed r78332: <http://trac.webkit.org/changeset/78332>
Comment 20 WebKit Commit Bot 2011-02-11 05:19:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 21 WebKit Commit Bot 2011-02-11 05:21:35 PST
The commit-queue encountered the following flaky tests while processing attachment 82112 [details]:

http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.
Comment 22 Ademar Reis 2011-02-14 12:06:55 PST
Revision r78332 cherry-picked into qtwebkit-2.1 with commit 30058fe <http://gitorious.org/webkit/qtwebkit/commit/30058fe>