Bug 51142 – size status bubble to it's contents on the code review page

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

size status bubble to it's contents on the code review page

[Ojan Vafai]

Created attachment 76692 [details]
Patch

[Ojan Vafai]

Created attachment 76693 [details]
Patch

[Adam Barth]

Comment on attachment 76693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76693&action=review

> BugsSite/code-review.js:259
> +    $('.statusBubble')[0].style.height = e.data.height;
> +    $('.statusBubble')[0].style.width = e.data.width;

This won't work in older browsers, but ok.

> BugsSite/code-review.js:289
> +      // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
> +      statusBubble.onload = handleStatusBubbleLoad;

You could use a live event handler, but this seems fine.

[Ojan Vafai]

Committed r74160: <http://trac.webkit.org/changeset/74160>

[Csaba Osztrogonác]

Reopen, because it is buggy:

After this patch, code review page doesn't work for me with Firefox,
I see the pretty diff, but I can't comment the source and I can't 
see the cq, review flags.

I tried with Chrome too. It works, but the 3 lines 
height textarea of the overall comment is so ugly.

[Ojan Vafai]

(In reply to comment #5)
> After this patch, code review page doesn't work for me with Firefox,
> I see the pretty diff, but I can't comment the source and I can't 
> see the cq, review flags.

I'll try to fix this this morning, but I leave on vacation in a couple hours. I didn't realize anyone on the WebKit project did code reviews in FF. If I don't get it in by then, it will be about 2 weeks before I can get back to it.

> I tried with Chrome too. It works, but the 3 lines 
> height textarea of the overall comment is so ugly.

It's hard to work with "ugly" as feedback. Patches are welcome.

[Antonio Gomes]

(In reply to comment #6)
> (In reply to comment #5)
> > After this patch, code review page doesn't work for me with Firefox,
> > I see the pretty diff, but I can't comment the source and I can't 
> > see the cq, review flags.
> 
> I'll try to fix this this morning, but I leave on vacation in a couple hours. I didn't realize anyone on the WebKit project did code reviews in FF. If I don't get it in by then, it will be about 2 weeks before I can get back to it.

I do reviewed on either Firefox or Chromium or Safari, whatever is easily accessible :)

> > I tried with Chrome too. It works, but the 3 lines 
> > height textarea of the overall comment is so ugly.

I also agree here, Ojan :( ... Not sure what I could feedback to you other than a visual adjective.

[Ojan Vafai]

OK. It's now functional in Firefox after http://trac.webkit.org/changeset/74276 and http://trac.webkit.org/changeset/74277. It's not pretty though. I assume it must be a difference between webkit's and Firefox's flexbox implementations.

Not planning on working on it more unless there's significant demand for this tool to work well in Firefox. Happy to do reviews for it though. :)

It's hard to develop on the tool for Firefox because the way we do so is via a Chrome extension. Hope this is good enough.