Bug 51140 - FormatBlock doesn't preserve typing style but it should
Summary: FormatBlock doesn't preserve typing style but it should
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-15 15:15 PST by Ryosuke Niwa
Modified: 2010-12-23 18:14 PST (History)
4 users (show)

See Also:


Attachments
fixes the bug (3.48 KB, patch)
2010-12-15 16:06 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-12-15 15:15:38 PST
InsertListCommand and IndentOutdentCommand both preserve typing style but FormatBlockCommand doesn't.  This is a bug.
Comment 1 Ryosuke Niwa 2010-12-15 16:06:37 PST
Created attachment 76706 [details]
fixes the bug
Comment 2 Ryosuke Niwa 2010-12-15 16:08:46 PST
(In reply to comment #1)
> Created an attachment (id=76706) [details]
> fixes the bug

It seems like there are some edge cases in which typing style isn't preserved.  But we should address each of such edge case in a separate bug since InsertListCommand and IndentOutdentCommand seem to have similar issues.
Comment 3 WebKit Commit Bot 2010-12-23 18:14:42 PST
Comment on attachment 76706 [details]
fixes the bug

Clearing flags on attachment: 76706

Committed r74601: <http://trac.webkit.org/changeset/74601>
Comment 4 WebKit Commit Bot 2010-12-23 18:14:48 PST
All reviewed patches have been landed.  Closing bug.