RESOLVED FIXED 51137
IOSurface bounds checks on bytesPerRow and allocSize are incorrect 
https://bugs.webkit.org/show_bug.cgi?id=51137
Summary IOSurface bounds checks on bytesPerRow and allocSize are incorrect
Matthew Delaney
Reported 2010-12-15 14:56:34 PST
Since the IOSurfaceAlignProperty functions may align bytesPerRow and allocSize for reasons other than not allowing the values to be too large, bounds checking off of their returned values is not correct. This patch will remove those incorrect bounds checks.
Attachments
Patch (1.44 KB, patch)
2010-12-15 15:05 PST, Matthew Delaney 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2010-12-15 15:05:21 PST
Created attachment 76690 [details] Patch
Eric Seidel (no email)
Comment 2 2010-12-15 15:15:41 PST
Comment on attachment 76690 [details] Patch Which tests? On which platform?
Simon Fraser (smfr)
Comment 3 2010-12-15 15:20:18 PST
Comment on attachment 76690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76690&action=review > WebCore/ChangeLog:8 > + No new tests added - many current canvas layout tests fail because of this incorrect bounds check. You should clarify that tests will only fail for those using this new functionality.
Matthew Delaney
Comment 4 2010-12-15 15:28:20 PST
Yea, exactly. Only on my local build using this new functionality (IOSurfaces) are any of the usual tests failing. This patch will fix those - not any tests failing on the bots. This is now reflected in the changelog.
Matthew Delaney
Comment 5 2010-12-15 15:28:31 PST
Committed r74148: <http://trac.webkit.org/changeset/74148>
Note You need to log in before you can comment on or make changes to this bug.