Bug 51132 - [v8] Do not install accessors if element could not be retrieved with it
Summary: [v8] Do not install accessors if element could not be retrieved with it
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: anton muhin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-15 13:31 PST by anton muhin
Modified: 2013-05-02 11:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2010-12-15 15:22 PST, anton muhin 		eric: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2010-12-15 13:31:50 PST 
[v8] Do not install accessors if element could not be retrieved with it
Comment 1 anton muhin 2010-12-15 15:22:04 PST 
Created attachment 76694 [details]
Patch
Comment 3 Nate Chapin 2010-12-16 09:11:53 PST 
What's the reason for this patch?  Should it have a layout test?
Comment 4 anton muhin 2010-12-16 09:20:34 PST 
I didn't manage (yet) to create a proper layout test.  The reason is to fix Chromium bug http://code.google.com/p/chromium/issues/detail?id=63241 (see comment #2)

And it does fix it :)

(In reply to comment #3)
> What's the reason for this patch?  Should it have a layout test?
Comment 5 Nate Chapin 2010-12-16 09:42:11 PST 
Given that this is a bugfix, we really should have either a layout test or a good case for why one isn't feasible.

I'm happy to help in any way I can to reduce the case provided in the chromium bug report.
Comment 6 Eric Seidel (no email) 2010-12-24 01:43:44 PST 
Comment on attachment 76694 [details]
Patch

r- for lack of test or explanation why testing is impossible in the ChangeLog.
Comment 7 anton muhin 2010-12-24 01:45:15 PST 
I'll try another time to either test or explain better why it's involved.  But I don't have spare cycles right now, sorry.

(In reply to comment #6)
> (From update of attachment 76694 [details])
> r- for lack of test or explanation why testing is impossible in the ChangeLog.
Comment 8 Erik Arvidsson 2012-01-23 11:12:01 PST 
Comment on attachment 76694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76694&action=review

> WebCore/bindings/v8/V8DOMWindowShell.cpp:532
> +    // If there is no matching elements, do not install accessor.
> +    if (!doc->documentNamedItems(name)->length())
> +        return;

Why does this happen? I think we need to figure out how this can happen to proceed.
Comment 9 Anders Carlsson 2013-05-02 11:10:35 PDT 
V8 is gone from WebKit.