Bug 51108 - [Qt] [Symbian] Fix the build after changes in r73570
Summary: [Qt] [Symbian] Fix the build after changes in r73570
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC S60 3rd edition
: P1 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on: 43515
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-15 07:41 PST by Laszlo Gombos
Modified: 2011-01-04 05:49 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-12-15 07:41:21 PST 
The refactoring in r73570 broke the Symbian build; Below is the first build error:

make [...] jsbase.cpp

"JavaScriptCore\wtf/PageAllocation.h", line 102: Error:  #289: no instance of constructor "WTF::PageAllocation::PageAllocation" matches the argumentlist
            argument types are: (void *, size_t)
          return PageAllocation(OSAllocator::reserveAndCommit(size, usage, writable, executable), size);
                                ^
"JavaScriptCore\wtf/PageReservation.h", line 93: Error:  #289: no instance of constructor "WTF::PageReservation::PageReservation" matches the argument list
            argument types are: (void *, size_t, bool, bool)
          return PageReservation(OSAllocator::reserve(size, usage, writable, executable), size, writable, executable);
                                 ^
"JavaScriptCore\wtf/PageReservation.h", line 113: Error:  #20: identifier "writable" is undefined
          , m_writable(writable)
                       ^
"JavaScriptCore\wtf/PageReservation.h", line 114: Error:  #20: identifier "executable" is undefined
          , m_executable(executable)
                         ^
JavaScriptCore\API\jsbase.cpp: 0 warnings, 4 errors
Comment 1 Laszlo Gombos 2011-01-04 05:49:24 PST 
The build issue has been resolved by r74297 and r74520. Reimplementing the allocator for Symbian is tracked by bug 51128. Closing this bug.