Bug 51089 - text-combine value name changed
Summary: text-combine value name changed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 48538
  Show dependency treegraph
 
Reported: 2010-12-14 20:17 PST by Takumi Takano
Modified: 2010-12-14 22:49 PST (History)
4 users (show)

See Also:


Attachments
Proposed patch. (5.72 KB, patch)
2010-12-14 20:40 PST, Takumi Takano
mitz: review-
Details | Formatted Diff | Diff
New proposed patch. (6.54 KB, patch)
2010-12-14 21:26 PST, Takumi Takano
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takumi Takano 2010-12-14 20:17:37 PST
text-combine's value names were changed from "none|cluster|upright" to "none|horizontal" in the latest css3 proposal.
Comment 1 Takumi Takano 2010-12-14 20:40:49 PST
Created attachment 76623 [details]
Proposed patch.
Comment 2 mitz 2010-12-14 20:50:28 PST
Comment on attachment 76623 [details]
Proposed patch.

Good, but you should also update the size of the bit field in StyleRareNomInheritedData.
Comment 3 Takumi Takano 2010-12-14 21:26:56 PST
Created attachment 76629 [details]
New proposed patch.

Changed textCombine field size in StyleRareNonInheritedData.h.
Comment 4 WebKit Commit Bot 2010-12-14 22:47:08 PST
The commit-queue encountered the following flaky tests while processing attachment 76629 [details]:

inspector/styles-source-offsets.html bug 51095 (authors: apavlov@chromium.org and pfeldman@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-12-14 22:49:01 PST
Comment on attachment 76629 [details]
New proposed patch.

Clearing flags on attachment: 76629

Committed r74098: <http://trac.webkit.org/changeset/74098>
Comment 6 WebKit Commit Bot 2010-12-14 22:49:06 PST
All reviewed patches have been landed.  Closing bug.